Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring markup in sage/modular #34159

Closed
kwankyu opened this issue Jul 12, 2022 · 11 comments
Closed

Fix docstring markup in sage/modular #34159

kwankyu opened this issue Jul 12, 2022 · 11 comments

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 12, 2022

Part of #34157:

sage/modular/overconvergent/hecke_series.py:295:1: RST303 Unknown directive type "todo".
sage/modular/overconvergent/genus0.py:163:1: RST399 Document may not end with a transition.
sage/modular/hecke/module.py:629:1: RST215 Inline interpreted text or phrase reference start-string without end-string.
sage/modular/pollack_stevens/space.py:665:1: RST399 Content block expected for the "WARNING" directive; none found.
sage/modular/pollack_stevens/sigma0.py:313:1: RST303 Unknown directive type "todo".

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 832de2e

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34159

@kwankyu kwankyu added this to the sage-9.7 milestone Jul 12, 2022
@kwankyu

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:2

done and checked


New commits:

dc5ac64rst fixes in modular

@fchapoton
Copy link
Contributor

Branch: u/chapoton/34159

@fchapoton
Copy link
Contributor

Commit: dc5ac64

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

Changed branch from u/chapoton/34159 to u/klee/34159

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

comment:4

My commit contains

diff --git a/src/sage/modular/overconvergent/hecke_series.py b/src/sage/modular/overconvergent/hecke_series.py
index 007b729b25..e4028f8d10 100644
--- a/src/sage/modular/overconvergent/hecke_series.py
+++ b/src/sage/modular/overconvergent/hecke_series.py
@@ -302,11 +302,9 @@ def ech_form(A, p):
     INPUT:
 
     - ``A`` -- matrix over ``Zmod(p^m)`` for some m
-    - ``p`` - prime p
+    - ``p`` -- prime p
 
-    OUTPUT:
-
-    matrix over ``Zmod(p^m)``
+    OUTPUT: matrix over ``Zmod(p^m)``
 
     EXAMPLES::

New commits:

832de2eChange - to --

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

Changed commit from dc5ac64 to 832de2e

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

comment:5

LGTM.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2022

Reviewer: Kwankyu Lee

@vbraun
Copy link
Member

vbraun commented Aug 1, 2022

Changed branch from u/klee/34159 to 832de2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants