Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importlib_metadata to Sphinx's dependencies #34200

Closed
jhpalmieri opened this issue Jul 19, 2022 · 9 comments
Closed

Add importlib_metadata to Sphinx's dependencies #34200

jhpalmieri opened this issue Jul 19, 2022 · 9 comments

Comments

@jhpalmieri
Copy link
Member

Right now ./configure && make sphinx finishes successfully, but the sphinx log file says

ERROR: Could not find a version that satisfies the requirement importlib-metadata>=4.4; python_version < "3.10" (from sphinx) (from versions: none)
ERROR: No matching distribution found for importlib-metadata>=4.4; python_version < "3.10"

We can fix this by adding importlib_metadata to the sphinx/dependencies file.

Component: packages: standard

Author: John Palmieri

Branch/Commit: 95c79ab

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34200

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/sphinx-dependencies

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2022

Commit: d54140e

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2022

comment:2

I think six can be removed - it no longer appears in https://github.com/sphinx-doc/sphinx/blob/v4.4.0/setup.py (install_requires)


New commits:

d54140etrac 34200: add importlib_metadata to build/pkgs/sphinx/dependencies

@jhpalmieri
Copy link
Member Author

comment:3

sphinx builds without six and doesn't report any errors, so let's remove that, too.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2022

Changed commit from d54140e to 95c79ab

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 19, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

95c79abtrac 34200: add importlib_metadata to and remove six from

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2022

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member Author

comment:7

Thanks! I think we can also remove six from a few other dependencies: cycler, prompt_toolkit, and traitlets. But we're far from being able to excise it altogether since lots of other packages require it.

@vbraun
Copy link
Member

vbraun commented Aug 1, 2022

Changed branch from u/jhpalmieri/sphinx-dependencies to 95c79ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants