Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive furo #34252

Closed
kwankyu opened this issue Jul 30, 2022 · 25 comments
Closed

Revive furo #34252

kwankyu opened this issue Jul 30, 2022 · 25 comments
Labels
c: documentation p: critical / 2 t: bug
Milestone
sage-9.7

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 30, 2022

Specifically html/en/index.html page is now based on furo's page.html for furo theme.

Along the way, we fix here and there so that

  • pdf docs also build
  • logo links to the documentation root
  • search page works
  • white sage logo is transparent

Hence our doc in furo theme is now quite functional.

CC: @yuan-zhou @tobiasdiez

Component: documentation

Author: Kwankyu Lee

Branch/Commit: 73e5aa3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34252
@kwankyu kwankyu added this to the sage-9.7 milestone Jul 30, 2022
@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 30, 2022

Branch: u/klee/34252

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 30, 2022

Commit: 9d1e07a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

9d1e07aRevive furo

@kwankyu

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Changed commit from 9d1e07a to f19b597

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f19b597Add link to the logo

@kwankyu

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

09d5f5cFix the logo link for reference
ae75d53Fix a subtle reference problem for build_options

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Changed commit from f19b597 to ae75d53

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

3519bedRun docbuild workflow with single thread

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Changed commit from ae75d53 to 3519bed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1274718Fix a suspicious part of categories doc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 3519bed to 1274718

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e5b1f7eAdd search.html

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from 1274718 to e5b1f7e

@kwankyu

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ebd3b77Better pygments style

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from e5b1f7e to ebd3b77

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Changed commit from ebd3b77 to 73e5aa3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 1, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

73e5aa3Make white logo transparent to match with furo

@kwankyu

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Member

mkoeppe commented Aug 1, 2022

comment:15

This looks excellent.

@mkoeppe
Copy link
Member

mkoeppe commented Aug 1, 2022

Reviewer: Matthias Koeppe

@kwankyu
Copy link
Collaborator Author

kwankyu commented Aug 1, 2022

comment:16

Thank you!

@vbraun
Copy link
Member

vbraun commented Aug 4, 2022

Changed branch from u/klee/34252 to 73e5aa3

@vbraun vbraun closed this as completed in 4236744 Aug 4, 2022
@mkoeppe mkoeppe mentioned this issue Aug 6, 2022
Closed
@tobiasdiez tobiasdiez mentioned this issue Sep 7, 2022
Closed
@mkoeppe mkoeppe mentioned this issue Aug 6, 2022
Closed
This was referenced Aug 7, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mkoeppe