Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker-in-docker available in Gitpod #34255

Closed
mkoeppe opened this issue Jul 31, 2022 · 16 comments
Closed

Make docker-in-docker available in Gitpod #34255

mkoeppe opened this issue Jul 31, 2022 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 31, 2022

This can be convenient for portability testing (tox -e docker-...), in particular

CC: @tobiasdiez @dimpase

Component: user interface

Author: Matthias Koeppe

Branch/Commit: 72925f0

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34255

@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 31, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 31, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Commit: b35341e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b35341edocker/.gitpod.Dockerfile: Install some basic system package

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

72925f0docker/.gitpod.Dockerfile: Install lsb-release

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 31, 2022

Changed commit from b35341e to 72925f0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 31, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 2, 2022

comment:6

Ready for review

@mkoeppe

This comment has been minimized.

@kwankyu

This comment has been minimized.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 21, 2022

comment:8

I am positive with the branch.

This branch seems to add a slight amount of time to the already long time that gitpod takes just to get to the command line prompt. Thus I wonder if the gitpod link is a useful addition to sage trac.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2022

comment:9

I can't say that I use gitpod regularly myself. To me the main utility of it is for situations when one is away from one's main developer machine

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 21, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 21, 2022

comment:10

LGTM. It works well.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2022

comment:11

Thank you!

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/make_docker_in_docker_available_in_gitpod to 72925f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants