-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker-in-docker available in Gitpod #34255
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Matthias Koeppe |
comment:6
Ready for review |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:8
I am positive with the branch. This branch seems to add a slight amount of time to the already long time that gitpod takes just to get to the command line prompt. Thus I wonder if the gitpod link is a useful addition to sage trac. |
comment:9
I can't say that I use gitpod regularly myself. To me the main utility of it is for situations when one is away from one's main developer machine |
Reviewer: Kwankyu Lee |
comment:10
LGTM. It works well. |
comment:11
Thank you! |
Changed branch from u/mkoeppe/make_docker_in_docker_available_in_gitpod to |
This can be convenient for portability testing (
tox -e docker-...
), in particulartox -e docker-...-incremental
(tox -e docker-...-incremental #34228), which needs to docker-pull multi-gigabyte imagesCC: @tobiasdiez @dimpase
Component: user interface
Author: Matthias Koeppe
Branch/Commit:
72925f0
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/34255
The text was updated successfully, but these errors were encountered: