Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimplicialComplex: Add method is_subcomplex #34294

Closed
mkoeppe opened this issue Aug 6, 2022 · 8 comments
Closed

SimplicialComplex: Add method is_subcomplex #34294

mkoeppe opened this issue Aug 6, 2022 · 8 comments
Labels
c: geometry p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 6, 2022

... in analogy to cubical and polyhedral complexes

(from #33586)

CC: @yuan-zhou @jhpalmieri

Component: geometry

Author: John Palmieri

Branch/Commit: a597465

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34294
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 6, 2022
@jhpalmieri
Copy link
Member

Branch: u/jhpalmieri/simplicial_complex_is_subcomplex

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

Commit: a597465

@jhpalmieri
Copy link
Member

comment:2

How about this?

New commits:

a597465trac 34294: is_subcomplex method for simplicial complexes

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 7, 2022

comment:3

Great! LGTM

@jhpalmieri
Copy link
Member

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/jhpalmieri/simplicial_complex_is_subcomplex to a597465

@vbraun vbraun closed this as completed in 08b5040 Aug 29, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe