Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh the Zariski-vanKampen file #34299

Closed
fchapoton opened this issue Aug 7, 2022 · 11 comments
Closed

refresh the Zariski-vanKampen file #34299

fchapoton opened this issue Aug 7, 2022 · 11 comments
Labels
c: algebraic geometry p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

pep8 standard and other code details

CC: @tscrim @kwankyu @slel

Component: algebraic geometry

Author: Frédéric Chapoton

Branch/Commit: 5f3d872

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34299
@fchapoton fchapoton added this to the sage-9.7 milestone Aug 7, 2022
@fchapoton
Copy link
Contributor Author

New commits:

7d70a03refresh Zariski-VanKampen file

@fchapoton
Copy link
Contributor Author

Commit: 7d70a03

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34299

@fchapoton
Copy link
Contributor Author

comment:2

green bot, so please review

@tscrim
Copy link
Collaborator

tscrim commented Aug 8, 2022

comment:3

The branch is reporting a merge conflict.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5f3d872Merge branch 'u/chapoton/34299' in latest develop

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 8, 2022

Changed commit from 7d70a03 to 5f3d872

@fchapoton
Copy link
Contributor Author

comment:5

indeed, 9.7.b8 has just been released.

rebased

@tscrim
Copy link
Collaborator

tscrim commented Aug 8, 2022

comment:6

Thanks. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 8, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34299 to 5f3d872

@vbraun vbraun closed this as completed in 60d94ce Aug 30, 2022
This was referenced Aug 29, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe