Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvexSet_base.representative_point, Polyhedron_base.an_affine_basis for unbounded polyhedra #34326

Closed
mkoeppe opened this issue Aug 9, 2022 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 9, 2022

ConvexSet_base.representative_point generalizes Polyhedron_base.representative_point.
We implement it via an_affine_basis.

We extend the implementation of that so it handles unbounded polyhedra.

CC: @yuan-zhou @jplab @kliem @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 6522eff

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34326

@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 9, 2022
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title ConvexSet_base.representative_point ConvexSet_base.representative_point, Polyhedron_base.an_affine_basis for unbounded polyhedra Aug 9, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Commit: 5f3a8ed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f0708e7RelativeInterior.representative_point: New
5f3a8edConvexSet_base._some_elements_: Provide a default implementation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Changed commit from 5f3a8ed to bfe56c6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bfe56c6Polyhedron_base1.an_affine_basis: Implement for the non-pointed case

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Dependencies: #32159

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 9, 2022

Changed dependencies from #32159 to none

@tscrim
Copy link
Collaborator

tscrim commented Aug 11, 2022

comment:9

The documentation of an_affine_basis() is now incorrect as it doesn't need to be a polytope (this is why I prefer self instead of "this/the foo"). The main thing is the one-line description, but I would include the details about unbounded polyhedra in the "main" doc rather than just with the example. Otherwise LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

6522effPolyhedron_base1.an_affine_basis: Update documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2022

Changed commit from bfe56c6 to 6522eff

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 11, 2022

comment:11

Thanks, good idea, done

@tscrim
Copy link
Collaborator

tscrim commented Aug 11, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 11, 2022

comment:12

Green bot => positive review.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 11, 2022

comment:13

Thanks! Build&Test bot is green.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/convexset_base_representative_point to 6522eff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants