-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bool(expr1 != expr2)
for nontrivially equal expressions
#34341
Labels
Milestone
Comments
Commit: |
Author: Thierry Monteil |
New commits:
|
sagetrac-tmonteil
mannequin
changed the title
boo(expr1 != expr2) misbehaves when the expressions are nontrivially equal
bool(expr1 != expr2) misbehaves when the expressions are nontrivially equal
Aug 11, 2022
This comment has been minimized.
This comment has been minimized.
comment:5
Thanks for fixing this. |
Reviewer: Samuel Lelièvre |
slel
changed the title
bool(expr1 != expr2) misbehaves when the expressions are nontrivially equal
Fix Aug 11, 2022
bool(expr1 != expr2)
for nontrivially equal expressions
Changed branch from u/tmonteil/boo_expr1____expr2__misbehaves_when_the_expressions_are_nontrivially_equal to |
This was referenced Aug 29, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As reported on sage-devel:
Note that
This is due to calling
is_trivial_zero
insteadof
is_zero
in the__bool__
method for symbolic expressions.The fix provided by this ticket is not intended to fix other existing
bool(expr1 != expr2)
issues (e.g. #33698).CC: @hemmecke @rwst
Component: symbolics
Author: Thierry Monteil
Branch/Commit:
5ca40a8
Reviewer: Samuel Lelièvre
Issue created by migration from https://trac.sagemath.org/ticket/34341
The text was updated successfully, but these errors were encountered: