Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl configure --without-libmetalink no longer works #34360

Closed
RefurioAnachro opened this issue Aug 14, 2022 · 15 comments
Closed

curl configure --without-libmetalink no longer works #34360

RefurioAnachro opened this issue Aug 14, 2022 · 15 comments

Comments

@RefurioAnachro
Copy link

During a docker build (after applying u/saraedum/34242 's changes, which are good and necessary) I got this:

[curl-7.84.0] configure: error: --with-libmetalink no longer works!
[...]
[curl-7.84.0] Error configuring curl-7.84.0
[...]
The following package(s) may have failed to build [...]
[...]
* package:         curl-7.84.0

Libmetalink is no longer supported by curl, and apparently this also errors out on --without-libmetalink!

https://daniel.haxx.se/blog/2021/06/07/bye-bye-metalink-in-curl/

CC: @saraedum @dimpase

Component: packages: standard

Author: Robert Figura

Branch/Commit: c42eef0

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34360

@RefurioAnachro
Copy link
Author

Commit: bf6aeb9

@RefurioAnachro
Copy link
Author

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

comment:2

This makes no sense as a separate ticket. This should be part of the review of #34242. I think you can just push your commit to the ticket there.

@mkoeppe mkoeppe removed this from the sage-9.7 milestone Aug 14, 2022
@RefurioAnachro
Copy link
Author

comment:3

It's a problem with recent curl versions. It's also still present in 9.7.beta8 and rebuilding artifacts should fail there, too.

It does not depend on #34242, that's just related to the only way I tried to build. Sorry for the excess information. It's also not a duplicate. But thanks for linking saraedum in.

@RefurioAnachro RefurioAnachro added this to the sage-9.7 milestone Aug 14, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

comment:4

The branch on the ticket has no relation to the description

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

c42eef0fix #34360: curl configure --without-libmetalink no longer works

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2022

Changed commit from bf6aeb9 to c42eef0

@RefurioAnachro
Copy link
Author

comment:6

I was just wondering where it had gone. My fault, thanks!

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

comment:8

I see, this is conditional on SAGE_FAT_BINARY=yes, so it has slipped through testing the upgrade in #34176.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

comment:9

Please put your full name in the Authors field in the ticket box

@RefurioAnachro
Copy link
Author

comment:10

Thanks for giving me a hand, it's my first attempt to contribute.

@RefurioAnachro
Copy link
Author

Author: Robert Figura

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

comment:12

Your fix works well, thanks very much!

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 14, 2022

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Aug 29, 2022

Changed branch from u/gh-RefurioAnachro/curl-without-libmetalink to c42eef0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants