Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.manifolds, sage.tensor: Remove imports from sage.arith.all, sage.rings.all #34428

Closed
mkoeppe opened this issue Aug 25, 2022 · 8 comments
Closed

sage.manifolds, sage.tensor: Remove imports from sage.arith.all, sage.rings.all #34428

mkoeppe opened this issue Aug 25, 2022 · 8 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 25, 2022

Part of #34201

CC: @tscrim @egourgoulhon

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: e7af9f3

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34428
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 25, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Branch: u/mkoeppe/sage_manifolds__sage_tensor__remove_imports_from_sage_arith_all__sage_rings_all

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

New commits:

e7af9f3sage.manifolds, sage.tensor: Remove imports from sage.arith.all, sage.rings.all

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 25, 2022

Commit: e7af9f3

@egourgoulhon
Copy link
Member

comment:3

LGTM. Thanks!

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 26, 2022

comment:4

Thanks

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/mkoeppe/sage_manifolds__sage_tensor__remove_imports_from_sage_arith_all__sage_rings_all to e7af9f3

@vbraun vbraun closed this as completed in bcfab68 Aug 30, 2022
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe