New implementation class VectorFieldDualFreeModule

[mkoeppe]

to take over the special case of linear differential forms from DiffFormFreeModule, as done in #34474/#30241 with FiniteRankDualFreeModule.

Depends on #30241
Depends on #34486

CC: @egourgoulhon

Component: manifolds

Author: Matthias Koeppe

Branch/Commit: 7c04959

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34501

[mkoeppe]

comment:2

(Is this a good name?)

[egourgoulhon]

comment:3

Replying to Matthias Köppe:

(Is this a good name?)

I would say yes. At least it is on the same footing with respect to VectoFieldFreeModule as FiniteRankDualFreeModule is with respect to FiniteRankFreeModule.

[mkoeppe]

Dependencies: #30241

[mkoeppe]

Branch: u/mkoeppe/new_implementation_class_vectorfielddualfreemodule

[mkoeppe]

comment:6

There's one failure "The following tests failed: _test_zero", not sure what's happening there

---

New commits:

803f7e4	Make FiniteRankFreeModule.tensor_module(0, 1) return the dual (#34474)
a1b32c0	Merge #34474
94f59b8	FiniteRankDualFreeModule: New, remove special case from ExtPowerDualFreeModule
37e41b9	FiniteRankDualFreeModule.tensor_type: New; add tensor_product doctests
5044024	FiniteRankDualFreeModule: Doc fixes
84d7b5e	ExtPower[Dual]FreeModule, FiniteRankDualFreeModule: Add docstring to construction method
b5c666c	Merge #30241
2ea164e	src/sage/manifolds/differentiable/diff_form_module.py (VectorFieldDualFreeModule): New

[mkoeppe]

Commit: 2ea164e

[mkoeppe]

Changed dependencies from #30241 to #30241, #34486

[sagetrac-git]

Changed commit from 2ea164e to af96b06

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0d2539a	VectorFieldModule: Faster fast path for tensor_module, exterior_power, dual_exterior_power
f06fc5e	Merge #34486
c7428e2	src/sage/manifolds/differentiable/diff_form_module.py (VectorFieldDualFreeModule): New
8bfb9ff	VectorFieldFreeModule.tensor_module: For (0,1), use the dual
af96b06	src/sage/manifolds/differentiable/diff_form_module.py: Update doctest output

[sagetrac-git]

Changed commit from af96b06 to bc99257

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bc99257

src/sage/manifolds/differentiable/diff_form_module.py: Fix doctests

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0155026

src/sage/manifolds/differentiable/diff_form_module.py: Remove some doctests on coercions

[sagetrac-git]

Changed commit from bc99257 to 0155026

[mkoeppe]

Author: Matthias Koeppe

[egourgoulhon]

comment:12

LGTM.
In the main docstring of diff_form_module.py it would be nice to add that the specific case p=1 of M parallelizable is implemented via VectorFieldDualFreeModule.
You may also want to update the AUTHORS field.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4c9be6b	src/sage/manifolds/differentiable/diff_form_module.py: doc: add that the case p=1 of M parallelizable is implemented via VectorFieldDualFreeModule
06710c1	src/sage/manifolds/differentiable/diff_form_module.py, vectorfield_module.py: Update copyright using 'git blame -w --date=format:%Y FILE.py | sort -k2', add to AUTHORS

[sagetrac-git]

Changed commit from 0155026 to 06710c1

[egourgoulhon]

comment:14

Thanks for the changes and sorry for the delay in the feedback. Just one typo in the docstring of DiffFormFreeModule:

-   For the special case of `-forms, use the class :class:`VectorFieldDualFreeModule`.
+   For the special case of `1-forms, use the class :class:`VectorFieldDualFreeModule`.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7c04959

src/sage/manifolds/differentiable/diff_form_module.py: Fix typo in docstring

[sagetrac-git]

Changed commit from 06710c1 to 7c04959

[egourgoulhon]

comment:16

Thanks!

[egourgoulhon]

Reviewer: Eric Gourgoulhon

[mkoeppe]

comment:18

Thank you!

[vbraun]

Changed branch from u/mkoeppe/new_implementation_class_vectorfielddualfreemodule to 7c04959