Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix giac build to work with pari 2.15 #34586

Closed
mkoeppe opened this issue Sep 25, 2022 · 17 comments
Closed

Fix giac build to work with pari 2.15 #34586

mkoeppe opened this issue Sep 25, 2022 · 17 comments
Labels
c: packages: standard r: invalid t: bug

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2022

split out from #34537

A workaround is documented in https://trac.sagemath.org/wiki/ReleaseTours/sage-9.7#AvailabilityofSage9.7andinstallationhelp but we should get this in urgently.

Depends on #34496

Upstream: Reported upstream. No feedback yet.

CC: @videlec @antonio-rojas @sagetrac-parisse

Component: packages: standard

Branch/Commit: u/mkoeppe/fix_giac_build_to_work_with_pari_2_15 @ 041d16b

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34586
@mkoeppe mkoeppe added this to the sage-9.8 milestone Sep 25, 2022
@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 25, 2022

Branch: u/mkoeppe/fix_giac_build_to_work_with_pari_2_15

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 25, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 25, 2022

New commits:

041d16bANYARG giac patch

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 25, 2022

Commit: 041d16b

@antonio-rojas
Copy link
Contributor

comment:5

I'm not convinced that a broken build is worse than the build working and then having many things broken at runtime (all the test failures reported in #34537). If anything, system 2.15 should be rejected until #34537 is merged.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 25, 2022

comment:7

OK, that's probably better

@dimpase
Copy link
Member

dimpase commented Sep 30, 2022

comment:8

We should disallow using of pari 2.15 from the system. I'll make patch - we already getting many reports on sage-devel etc due to this issus.

@dimpase
Copy link
Member

dimpase commented Sep 30, 2022

comment:9

Replying to Dima Pasechnik:

We should disallow using of pari 2.15 from the system. I'll make patch - we already getting many reports on sage-devel etc due to this issus.

Please see #34496 for the fix.

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 30, 2022

Changed reviewer from Matthias Koeppe to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 30, 2022

Changed author from Vincent Delecroix to none

@mkoeppe
Copy link
Member Author

mkoeppe commented Sep 30, 2022

Dependencies: #34496

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Sep 30, 2022
@dimpase
Copy link
Member

dimpase commented Sep 30, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Oct 4, 2022

comment:12

upstream report: https://xcas.univ-grenoble-alpes.fr/forum/viewtopic.php?f=3&t=2800

@dimpase
Copy link
Member

dimpase commented Oct 4, 2022

Upstream: Reported upstream. No feedback yet.

@antonio-rojas
Copy link
Contributor

comment:13

Not sure if relevant for Sage, but the giac test suite segfaults here with pari 2.15 (after applying the build fix).

@dimpase
Copy link
Member

dimpase commented Oct 4, 2022

comment:14

should be discussing on #34496, not here, sorry.

@dimpase
Copy link
Member

dimpase commented Oct 4, 2022

comment:15

oops, I meant #34537

@mkoeppe mkoeppe closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dimpase @mkoeppe @antonio-rojas