Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 internet doctest failing in graphs/isgci.py #34612

Closed
seblabbe opened this issue Sep 29, 2022 · 8 comments
Closed

1 internet doctest failing in graphs/isgci.py #34612

seblabbe opened this issue Sep 29, 2022 · 8 comments

Comments

@seblabbe
Copy link
Contributor

With 9.8.beta0, the command

sage -t --optional=sage,internet src/sage/graphs/isgci.py

gives

sage -t --random-seed=77042496144687512046172744154893811378 src/sage/graphs/isgci.py
**********************************************************************
File "src/sage/graphs/isgci.py", line 871, in sage.graphs.isgci.GraphClasses.update_db
Failed example:
    graph_classes.update_db()  # optional - internet
Expected nothing
Got:
    Database downloaded
**********************************************************************
1 item had failures:
   1 of   2 in sage.graphs.isgci.GraphClasses.update_db
    [86 tests, 1 failure, 2.26 s]
----------------------------------------------------------------------
sage -t --random-seed=77042496144687512046172744154893811378 src/sage/graphs/isgci.py  # 1 doctest failed
----------------------------------------------------------------------

Component: doctest coverage

Author: Sébastien Labbé

Branch/Commit: 1ef60e4

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34612

@seblabbe seblabbe added this to the sage-9.8 milestone Sep 29, 2022
@seblabbe
Copy link
Contributor Author

comment:1

Seems to come from a recent commit of David, maybe #34211:

$ git blame src/sage/graphs/isgci.py | grep downloaded -C3
b9669295447b (Jori Mäntysalo    2017-02-18 11:56:48 +0200  869)         EXAMPLES::
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  870) 
2302af6f35af (dcoudert          2022-08-08 16:57:43 +0200  871)             sage: graph_classes.update_db()  # optional - internet
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  873)         """
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  874)         self._download_db()
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  875) 
1b1f7a220368 (Frédéric Chapoton 2016-05-11 17:35:09 +0200  876)         print("Database downloaded")
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  877) 
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  878)         self.classes.clear_cache()
e3be127f3853 (Nathann Cohen     2012-03-06 18:35:23 +0100  879)         self.inclusions.clear_cache()

@seblabbe
Copy link
Contributor Author

Commit: 1ef60e4

@seblabbe
Copy link
Contributor Author

New commits:

1ef60e434612: fix failing internet doctest

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/34612

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@dcoudert
Copy link
Contributor

comment:3

LGTM.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/slabbe/34612 to 1ef60e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants