-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the kbd role in the doc #34629
Comments
Commit: |
New commits:
|
Branch: u/chapoton/34629 |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
I've found some more. Can I push some changes? |
Changed branch from u/chapoton/34629 to u/jhpalmieri/34629 |
comment:7
sure, please do. Typo in your commit
in src/doc/en/tutorial/interactive_shell.rst New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:9
Typo fixed, thank you for catching that. |
comment:10
oh, this breaks our rst linter, for instance
so we need to add this role to some list somewhere. But where ? |
comment:11
probably in src/tox.ini where there is a list "rst-roles" |
comment:12
let's see New commits:
|
Changed branch from u/jhpalmieri/34629 to u/chapoton/34629 |
comment:13
The linter is now happy. Let's wait for the rest of the reports. |
comment:14
good. John, please set to positive if you agree. |
comment:15
LGTM in code and in doc. |
Reviewer: Kwankyu Lee |
Changed author from Frédéric Chapoton to Frédéric Chapoton, John Palmieri |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/chapoton/34629 to |
in particular to represent the Tab key as can be seen already near the end of
https://doc.sagemath.org/html/en/installation/launching.html
CC: @tscrim @kwankyu @kliem @slel
Component: documentation
Author: Frédéric Chapoton, John Palmieri
Branch/Commit:
a0e1d3b
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/34629
The text was updated successfully, but these errors were encountered: