Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removal of some unused imports about string conversion #34844

Closed
fchapoton opened this issue Dec 13, 2022 · 7 comments
Closed

removal of some unused imports about string conversion #34844

fchapoton opened this issue Dec 13, 2022 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

as this may help to reduce compilation warnings

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: fc44813

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34844
@fchapoton fchapoton added this to the sage-9.8 milestone Dec 13, 2022
@fchapoton
Copy link
Contributor Author

Commit: fc44813

@fchapoton
Copy link
Contributor Author

New commits:

fc44813removal of some unused imports about string conversions

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34844

@fchapoton
Copy link
Contributor Author

comment:2

the doctest failure is unrelated

@tscrim
Copy link
Collaborator

tscrim commented Dec 14, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Dec 14, 2022

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 12, 2023

Changed branch from u/chapoton/34844 to fc44813

@vbraun vbraun closed this as completed in 9ffabc7 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton