Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernize some for loops in cython files #34847

Closed
fchapoton opened this issue Dec 14, 2022 · 11 comments
Closed

modernize some for loops in cython files #34847

fchapoton opened this issue Dec 14, 2022 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.8

Comments

@fchapoton
Copy link
Contributor

changing things like

for i from 0 <= i < n

to

for i in range(n)

There remains many, as can be seen using

git grep " from .*<=" src/sage/

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 16ef533

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/34847
@fchapoton fchapoton added this to the sage-9.8 milestone Dec 14, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34847

@fchapoton

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

16ef533modernize some for loops in cython files

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 14, 2022

Commit: 16ef533

@fchapoton
Copy link
Contributor Author

New commits:

16ef533modernize some for loops in cython files

@fchapoton

This comment has been minimized.

Sign in to view
@dcoudert
Copy link
Contributor

comment:4

all the changes seems OK and the patchbot is green. Do you plan to do more changes or you just forgot to set this ticket to needs review ?

@fchapoton
Copy link
Contributor Author

comment:5

juste oublié, rien d'autre prévu dans ce ticket

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:6

Bonnes fêtes !

@vbraun
Copy link
Member

vbraun commented Jan 12, 2023

Changed branch from u/chapoton/34847 to 16ef533

@vbraun vbraun closed this as completed in 6f63102 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @dcoudert