Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify jquery libraries in devel/sage and data/extcode #3543

Closed
sagetrac-mabshoff mannequin opened this issue Jul 3, 2008 · 6 comments
Closed

Unify jquery libraries in devel/sage and data/extcode #3543

sagetrac-mabshoff mannequin opened this issue Jul 3, 2008 · 6 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jul 3, 2008

We currently ship two copies of the jquery javascript library:

  • jQuery 1.2.6 - New Wave Javascript - $Rev: 5685 $ in devel/sage-main/sage/dsage/web/static/jquery.js
  • jQuery 1.2.3 - New Wave Javascript - $Rev: 4663 $ in data/extcode/notebook/javascript/jquery/jquery.js

But we should on ship one copy.

Cheers,

Michael

CC: @jasongrout @TimDumol

Component: build

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/3543

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-5.11 milestone Jul 3, 2008
@jasongrout jasongrout removed their assignment Dec 5, 2008
@jasongrout
Copy link
Member

comment:3

I'm not sure what is going on with dsage; someone familiar with dsage will have to look at that.

@jasongrout
Copy link
Member

comment:4

All that is needed is that dsage needs to change its /static directory to point to local/notebook/javascript/. I'm making this minor since:

  1. the small space wasted with duplicated code is not worth the risk of breaking dsage, especially since
  2. it seems that the future of dsage is uncertain.

Things work now.

@jasongrout
Copy link
Member

comment:5

Tim,

Can you comment on this ticket? You probably know more about this than anyone at this point.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented May 11, 2010

comment:6

dsage is gone, so that doesn't matter. The files in data/extcode/... are used by the old notebook (in sage.server.notebook). Since the old notebook isn't used anymore except in migration to the new one, the files should be safe to delete.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:11

The Sage library doesn't ship jquery. Various packages do, in particular sagenb, Sphinx, matplotlib, ppl, jsmol, IPython and WerkZeug. I don't think it's feasible to unify them, so close this ticket as "wontfix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants