Factory and pickling framework (part of coercion branch) #3623

robertwb · 2008-07-09T08:03:41Z

Uniqueness of parents makes Sage operate much more smoothly. This leads to an enormous amount of nearly identical caching code scattered throughout the library. This factory handles all the caching for you, and also provides a good pickling mechanism.

Component: coercion

Issue created by migration from https://trac.sagemath.org/ticket/3623

robertwb · 2008-07-09T08:16:34Z

comment:1

Code documented and works great/passes tests. Just need some doctests in factory.pyx (perhaps via a fake test class?)

sagetrac-anakha · 2008-09-06T15:54:02Z

comment:3

Needs to be rebased against 3.1.2.alpha4:

sage: hg_sage.apply('https://github.com/sagemath/sage-prod/files/10641263/3623-factory-2.patch.gz')
Attempting to load remote file: https://github.com/sagemath/sage/files/ticket3623/3623-factory-2.patch.gz?format=raw
Loading: [....]
cd "/Volumes/Place/anakha/sage-3.1.2.alpha4/devel/sage" && hg status
cd "/Volumes/Place/anakha/sage-3.1.2.alpha4/devel/sage" && hg status
cd "/Volumes/Place/anakha/sage-3.1.2.alpha4/devel/sage" && hg import   "/Users/anakha/.sage/temp/fullmetal.umn/58245/tmp_1.patch"
applying /Users/anakha/.sage/temp/fullmetal.umn/58245/tmp_1.patch
patching file sage/modules/free_module.py
Hunk #1 FAILED at 157
Hunk #2 FAILED at 261
2 out of 2 hunks FAILED -- saving rejects to file sage/modules/free_module.py.rej
abort: patch failed to apply

Otherwise, I like this very much after having gone through the pain of implementing a unique factory for a parent already, I would have wasted a week less if this had already been in sage.

robertwb · 2008-09-08T16:26:21Z

comment:4

Thanks. I'll rebase this as soon as 3.1.2 comes out (as I doubt this ticket will make it into there).

robertwb · 2008-09-23T23:11:01Z

Attachment: 3623-factory-1.patch.gz

robertwb · 2008-09-23T23:11:26Z

Attachment: 3623-factory-2.patch.gz

Attachment: 3623-factory-3.patch.gz

robertwb · 2008-09-23T23:12:25Z

comment:5

Attachment: 3623-factory-4.patch.gz

All four patches rebased.

robertwb · 2008-09-24T05:29:50Z

Attachment: 3623-factory-5.patch.gz

williamstein · 2008-11-28T21:36:39Z

comment:7

Hi Robert,

This bitrotted again. Sorry!

was@sage:~/build/sage-3.2.1.alpha1$ ./sage
----------------------------------------------------------------------
| Sage Version 3.2.1.alpha1, Release Date: 2008-11-26                |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: hg_sage.apply('https://github.com/sagemath/sage-prod/files/10641262/3623-factory-1.patch.gz')
Attempting to load remote file: https://github.com/sagemath/sage/files/ticket3623/3623-factory-1.patch.gz?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import   "/home/was/.sage/temp/sage/14985/tmp_0.patch"
applying /home/was/.sage/temp/sage/14985/tmp_0.patch
patching file setup.py
Hunk #1 FAILED at 533
1 out of 1 hunk FAILED -- saving rejects to file setup.py.rej
abort: patch failed to apply
sage:

Can you rebase it an email me asap so this can get properly refereed and not bitrot again.

robertwb · 2008-12-02T12:37:34Z

patches 1-5 folded and rebased onto 3.2.1

robertwb · 2008-12-02T12:42:03Z

comment:8

Attachment: 3623-all-3.2.1.patch.gz

OK, this is once again rebased.

sagetrac-mabshoff · 2008-12-02T15:46:15Z

comment:9

The patch applies cleanly against 3.2.1 and together with #4276 I am seeing two doctest failures:

sage -t -long "devel/sage/sage/structure/coerce.pyx"        
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 862:
    sage: V is W
Expected:
    False
Got:
    True
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 865:
    sage: cm.coercion_maps(V, W)
Expected:
    (None,
     Call morphism:
      From: Vector space of dimension 3 over Rational Field
      To:   Vector space of dimension 3 over Rational Field)
Got:
    (None, None)
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 870:
    sage: cm.coercion_maps(W, V)
Expected:
    (None,
     Call morphism:
      From: Vector space of dimension 3 over Rational Field
      To:   Vector space of dimension 3 over Rational Field)
Got:
    (None, Free module morphism defined by the matrix
    [1 0 0]
    [0 1 0]
    [0 0 1]
    Domain: Vector space of dimension 3 over Rational Field
    Codomain: Vector space of dimension 3 over Rational Field)
**********************************************************************
1 items had failures:
   3 of  21 in __main__.example_15
***Test Failed*** 3 failures.

I guess the first one is worrying while the rest is mostly a printing issue.

The other failure is:

sage -t -long "devel/sage/sage/schemes/elliptic_curves/ell_number_field.py"
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/devel/sage/sage/schemes/elliptic_curves/ell_number_field.py", line 667:
    sage: [E.tamagawa_exponent(P) for P in K(11).support()]
Exception raised:
    Traceback (most recent call last):
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_20[7]>", line 1, in <module>
        [E.tamagawa_exponent(P) for P in K(Integer(11)).support()]###line 667:
    sage: [E.tamagawa_exponent(P) for P in K(11).support()]
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_number_field.py", line 675, in tamagawa_exponent
        return self.local_data(P, proof).tamagawa_exponent()
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_number_field.py", line 401, in local_data
        return self._get_local_data(P,proof)
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_number_field.py", line 418, in _get_local_data
        self._local_data[P] = EllipticCurveLocalData(self, P, proof)
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_local_data.py", line 140, in __init__
        self._Emin, ch, self._val_disc, self._fp, self._KS, self._cp, self._split = self._tate(proof)
      File "/scratch/mabshoff/release-cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-packages/sage/schemes/elliptic_curves/ell_local_data.py", line 528, in _tate
        r = -pinv(12*c4) * (c6 + b2 * c4)
      File "element.pyx", line 1074, in sage.structure.element.RingElement.__mul__ (sage/structure/element.c:8580)
      File "coerce.pyx", line 697, in sage.structure.coerce.CoercionModel_cache_maps.bin_op (sage/structure/coerce.c:5808)
    TypeError: unsupported operand parent(s) for '*': 'Maximal Order in Number Field in a with defining polynomial x^2 + 11' and 'Number Field in a with defining polynomial x^2 + 11'
**********************************************************************

Cheers,

Michael

robertwb · 2008-12-02T20:18:39Z

Attachment: 3623-fix.patch.gz

apply after 3623-3.2.1-all.patch

robertwb · 2008-12-02T20:20:23Z

comment:10

OK, I fixed the doctests in coerce.pyx. The issue was that loads(dumps(V)) wasn't returning a new object anymore (this is good) so it wasn't testing what I wanted to test (equal but not identical parents).

The other one is almost certainly due to #4276, looking into that now.

sagetrac-mabshoff · 2008-12-02T21:05:39Z

comment:11

3623-fix.patch does indeed fix the problem and seem to not have any side effects, i.e. the doctest failure in ell_number_field.py is still there. No additional doctests did fail.

Cheers,

Michael

sagetrac-mabshoff · 2008-12-04T11:56:59Z

comment:12

Ok, since 3623-all-3.2.1.patch and 3623-fix.patch + the two patches from #4276 make all tests pass I am giving this a positive review. There might still be issues here, so if anyone does take a closer look please open another ticket. The cost of this bitrotting is too high, so if this blows up there is only me and not Robert to blame.

Cheers,

Michael

sagetrac-mabshoff · 2008-12-04T11:57:20Z

comment:13

Merged in Sage 3.2.2.alpha0

sagetrac-mabshoff · 2008-12-04T12:00:49Z

comment:14

One last remark: A couple doctests for the various "create_key" methods would be nice, but that can be done via a new ticket.

Cheers,

Michael

robertwb · 2008-12-04T20:09:04Z

comment:15

Thanks you. This one is a real pain to rebase, and I've wanted to use it elsewhere too.

Note that Mike Hansen did look at these during Sage Days 10, and the response was generally positive (though not formal).

robertwb added this to the sage-3.2.2 milestone Jul 9, 2008

robertwb added c: coercion labels Jul 9, 2008

robertwb self-assigned this Jul 9, 2008

robertwb added the s: needs review label Jul 31, 2008

sagetrac-anakha mannequin changed the title ~~Factory and pickling framework (part of coercion branch)~~ [needs rebase] Factory and pickling framework (part of coercion branch) Sep 6, 2008

robertwb changed the title ~~[needs rebase] Factory and pickling framework (part of coercion branch)~~ Factory and pickling framework (part of coercion branch) Sep 24, 2008

williamstein added s: needs work and removed s: needs review labels Nov 28, 2008

robertwb added s: needs review and removed s: needs work labels Dec 2, 2008

sagetrac-mabshoff mannequin added s: positive review and removed s: needs review labels Dec 4, 2008

sagetrac-mabshoff mannequin removed the s: positive review label Dec 4, 2008

sagetrac-mabshoff mannequin closed this as completed Dec 4, 2008

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Factory and pickling framework (part of coercion branch) #3623

Factory and pickling framework (part of coercion branch) #3623

robertwb commented Jul 9, 2008

robertwb commented Jul 9, 2008

sagetrac-anakha mannequin commented Sep 6, 2008

robertwb commented Sep 8, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 24, 2008

williamstein commented Nov 28, 2008

robertwb commented Dec 2, 2008

robertwb commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 2, 2008

robertwb commented Dec 2, 2008

robertwb commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

robertwb commented Dec 4, 2008

Factory and pickling framework (part of coercion branch) #3623

Factory and pickling framework (part of coercion branch) #3623

Comments

robertwb commented Jul 9, 2008

robertwb commented Jul 9, 2008

sagetrac-anakha mannequin commented Sep 6, 2008

robertwb commented Sep 8, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 23, 2008

robertwb commented Sep 24, 2008

williamstein commented Nov 28, 2008

robertwb commented Dec 2, 2008

robertwb commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 2, 2008

robertwb commented Dec 2, 2008

robertwb commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 2, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

sagetrac-mabshoff mannequin commented Dec 4, 2008

robertwb commented Dec 4, 2008