-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NTL to 5.5.2 release (latest upstream) #5731
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Changed keywords from none to upgrade |
comment:5
Attachment: ntl-5.5.2.p1.spkg.gz This works for me with all long tests. |
comment:6
two things.
Other than that I have no doubts that it works out of the box personally, and you save me from creating a spkg. |
comment:7
Installed fine for me on top of 4.7.alpha1, and all tests passed. (ubuntu linux 64-bit). Note that since several other spkgs use NTL (for example, eclib), someone should check that they all build ok. One way to do this would be to put the spkg into the next alpha and let the automatic testing system see what happens. |
comment:8
I have been using ntl-5.5.2 in sage-on-gentoo since
the following depend on ntl:
I have rebuild/updated all of those since 2009 so I don't expect any shocking results. |
comment:9
I am putting this for 4.7.1. Hopefully I'll find the time to give a proper review. |
comment:10
OK I had a closer look at the spkg. First of SPKG.txt hasn't been updated, the hg repo looks ok so I suppose you only changed the content of the src directory. This need a bit of work. I may elect to do the finishing bits if I have time this week. |
comment:11
So I have looked more closely. You updated the patches and everything but didn't update the info in SPKG.txt. What I will do is update SPKG.txt with your details make a nice ntl-5.5.2.spkg and post it on google-code and I will put myself and John Cremona as reviewer. Once that's done can you have a quick check and put it to positive review John? |
Author: Martin Raum |
Reviewer: Francois Bissey, John Cremona |
comment:12
New spkg upload on google-code, link in updated description. Let's get a final sign off on this. |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Francois Bissey, John Cremona to François Bissey, John Cremona |
comment:14
I am checking this now. John |
comment:15
Replying to @JohnCremona:
I started with a fresh build of 4.7.1.alpha0 which passes all tests; built the new spkg here (with SAGE_CHECK=yes"); did "sage -ba" followed by "sage -t -long", and all tests pass. The spkg itself is ok (though there's a typo "numbery" in the README, and William should probably not be the only spkg maintainer listed), so I am giving this a positive review and hop that it can go into the next alpha form 4.7.1. |
Merged: sage-4.7.1.alpha3 |
From http://www.shoup.net/ntl/doc/tour-changes.html (03.09.2010):
2009.08.14: Changes between NTL 5.5.1 and 5.5.2
MulAddTo
andMulSubFrom
for computingx += a*b
andx -= a*b
, wherex
anda
areZZ
's andb
is aZZ
or along
. In the case whereb
is along
, this may be much faster than writingmul(t, a, b); add(x, x, t)
. See ZZ.txt for details. These new routines are used in a number of places in NTL to get faster algorithms (for example, theLLL
routine).GF2EX
discovered by Berend-Benjamin Tams using thevalgrind
tool.2009.05.05: Changes between NTL 5.5 and 5.5.1
NTL_GMP_LIP
orNTL_GMP_HACK
), then the new version (4.3.0) of GMP implements theXGCD
functionality differently, so that the coefficients do not always agree with those returned by the classical extended Euclidean algorithm. This version of NTL corrects the coefficients, so that the "classical" coefficients are always produced, regardless of GMP's implementation. This version of NTL also works around a bug in GMP 4.3.0'sXGCD
code (although that bug should be fixed in GMP 4.3.1).configure
script has been slightly modified: there is a new configuration variableDEF_PREFIX
, whose value can be used to setPREFIX
,GMP_PREFIX
, andGF2X_PREFIX
in one stroke. Also, the (somewhat esoteric)configure
variablesGMP_LIBDIR
,GMP_INCDIR
,GF2X_LIBDIR
, andGF2X_INCDIR
have slightly different meanings now.2009.04.08: Changes between NTL 5.4.2 and 5.5
EOF
now conforms to standards.ErrorCallback
in tools.txt.gf2x
library for speeding up arithmetic inGF2X
(with help from Emmanuel Thomé). Details.GF2X
so that it works better with very large polynomials: large blocks of memory are released, recursive HalfGCD algorithms are used for large polynomials.void TraceMod(zz_p& x, const zz_pX& a, const zz_pXModulus& F)
(reported by Luca De Feo).SetCoeff
(reported by Luca De Feo).mat_zz_p transpose(const mat_zz_p& a)
(reported by Benoit Lacelle).So we should be able to drop a couple custom patches.
Cheers,
Michael
The current version in Sage (4.5.3) is NTL 5.4.2[.p12].
New spkg: http://spkg-upload.googlecode.com/files/ntl-5.5.2.spkg
CC: @JohnCremona
Component: packages: standard
Keywords: upgrade
Author: Martin Raum
Reviewer: François Bissey, John Cremona
Merged: sage-4.7.1.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/5731
The text was updated successfully, but these errors were encountered: