notebook: new modal jquery dialog boxes are covered by jmol 3d graphics

[williamstein]

Trac #7310 introduced nice modal jquery dialog boxes. Unfortunately, they do not play well at all with the output of jmol 3d graphics (java). See this screenshot:

http://wstein.org/home/wstein/patches/trac-7434.png

Component: notebook

Author: Alex Leone

Reviewer: Tim Dumol, Mitesh Patel

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/7434

[qed777]

comment:2

This appears to be relevant.

[sagetrac-acleone]

Attachment: trac_7434-jmol_modal_dialogs.patch.gz

Attachment: trac_7434-jmol_modal_dialogs_test.patch.gz

[sagetrac-acleone]

Author: Alex Leone

[sagetrac-acleone]

comment:3

trac_7434-jmol_modal_dialogs.patch: This patch hides all java applets on the page and puts grey boxes in their place when any modal prompts show up (in notebook_lib.js: function modal_prompt(...)).

trac_7434-jmol_modal_dialogs_test.patch: This patch adds a selenium test for the above patch.

[TimDumol]

comment:4

LGTM.

[TimDumol]

Reviewer: Tim Dumol

[qed777]

Rebased for SageNB 0.6 + queue in comment. Replaces earlier version.

[qed777]

comment:5

Attachment: trac_7434-jmol_modal_dialogs.2.patch.gz

Please ignore V2. I've just noticed that the patch doesn't work in Cr4, IE8, and S4 on Windows XP. It seems the WebKit browsers use applets instead of objects. IE8 uses objects, but the type attribute is empty.

V3 fixes this with jmolSetAppletCssClass and $('.jmol_applet').

[qed777]

comment:6

V3 is also rebased for

sagenb-0.6
trac_7249-jinja2_v9.5.patch
trac_7962-link-worksheets-zip-file.patch
trac_7969-escaped-backslash.patch
trac_4217-html-system-formatting.3.patch
trac_3083-print-documentation.5.patch
trac_6182-double-quotes-ws.2.patch
trac_5263-publish-url.patch
trac_7631-republish-name.patch
trac_6353-cookies-diff-ports.patch
trac_7207-sagenb-future-import.3.patch
trac_8000-utf-8-coding-directive.2.patch
trac_4450-cursor-wrap-last-cell.patch
trac_7848-misleading_HTML_cells.patch
trac_7963-download-multiple-worksheets.patch
trac_7752-delete-worksheet-quit.patch
trac_7996-invisible_text.patch
trac_6475-error-delete-data-file.patch
trac_5675-address-launch.patch
trac_7435-dir-var.patch
trac_3844-DATA_in_sys_path.2.patch
trac_6368-shift_tab_unindents.patch
trac_7434-jmol_modal_dialogs_test.patch
trac_7434-jmol_modal_dialogs.patch

[qed777]

Attachment: trac_7434-jmol_modal_dialogs.3.patch.gz

Fix WebKit, IE8 hiding. Rebase vs. queue in comment. Replaces previous.

[sagetrac-acleone]

comment:8

LGTM

[qed777]

Merged: sagenb-0.7

[qed777]

Changed reviewer from Tim Dumol to Tim Dumol, Mitesh Patel