Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: help screen talks about DIR variable, which was removed from the notebook a while ago #7435

Closed
williamstein opened this issue Nov 11, 2009 · 12 comments

Comments

@williamstein
Copy link
Contributor

So... delete the section about the DIR variable, or make sure it is defined as explained in the help screen. What do people prefer?

CC: @sagetrac-acleone @qed777

Component: notebook

Author: Tim Dumol

Reviewer: Alex Leone

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/7435

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 19, 2010

Adds the DIR variable

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 19, 2010

comment:1

Attachment: trac_7435-dir-var.patch.gz

This patch adds the DIR variable.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 19, 2010

Author: Tim Dumol

@TimDumol TimDumol mannequin added the s: needs review label Jan 19, 2010
@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Jan 19, 2010

comment:2

LGTM.

@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Jan 19, 2010

Reviewer: Alex Leone

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Attachment: trac_7435-dir-var.2.patch.gz

Rebased for SageNB 0.6 + queue in comment. Replaces previous.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Merged: sagenb-0.7

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:4

V2 is rebased for this queue:

sagenb-0.6
trac_7249-jinja2_v9.5.patch
trac_7962-link-worksheets-zip-file.patch
trac_7969-escaped-backslash.patch
trac_4217-html-system-formatting.3.patch
trac_3083-print-documentation.5.patch
trac_6182-double-quotes-ws.2.patch
trac_5263-publish-url.patch
trac_7631-republish-name.patch
trac_6353-cookies-diff-ports.patch
trac_7207-sagenb-future-import.3.patch
trac_8000-utf-8-coding-directive.2.patch
trac_4450-cursor-wrap-last-cell.patch
trac_7848-misleading_HTML_cells.patch
trac_7963-download-multiple-worksheets.patch
trac_7752-delete-worksheet-quit.patch
trac_7996-invisible_text.patch
trac_6475-error-delete-data-file.patch
trac_5675-address-launch.patch
trac_7435-dir-var.patch

@qed777 qed777 mannequin removed the s: positive review label Jan 25, 2010
@qed777 qed777 mannequin closed this as completed Jan 25, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Fix failed doctests. Replaces previous.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:5

Attachment: trac_7435-dir-var.3.patch.gz

V3 adds DIR = None near the top of twist.py, to fix failed doctests in cell.py and worksheet.py.

@qed777 qed777 mannequin added the s: needs work label Jan 25, 2010
@qed777 qed777 mannequin reopened this Jan 25, 2010
@qed777 qed777 mannequin added s: needs review and removed s: needs work labels Jan 25, 2010
@sagetrac-acleone
Copy link
Mannequin

sagetrac-acleone mannequin commented Jan 25, 2010

comment:7

LGTM.

@qed777 qed777 mannequin removed the s: positive review label Jan 25, 2010
@qed777 qed777 mannequin closed this as completed Jan 25, 2010
@williamstein
Copy link
Contributor Author

comment:9

Merged into sage-4.3.2 (post Minh's sage-4.3.2).

@qed777 qed777 mannequin mentioned this issue Feb 10, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants