Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M4RI source code needs looking at, as lint finds some issues. #7503

Closed
sagetrac-drkirkby mannequin opened this issue Nov 20, 2009 · 4 comments
Closed

M4RI source code needs looking at, as lint finds some issues. #7503

sagetrac-drkirkby mannequin opened this issue Nov 20, 2009 · 4 comments
Assignees
@malb
Labels
c: packages: standard r: invalid t: bug

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Nov 20, 2009

Whilst reviewing #7375 (upgrade M4RI to newest upstream release), for which I gave a positive review, I did notice some issues which should at least be investigated by Martin Albrecht. They are shown in a log file I attached to #7375

Overall the update of M4RI solves two obvious problems (#7171 and #7037), and is clearly an improvement over the previous version of M4RI, so I felt fully justified in giving #7375 a positive review, even though I am aware of problems in the source code.

Dave

Upstream: Reported upstream. Developers acknowledge bug.

Component: packages: standard

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/7503
@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-5.11 milestone Nov 20, 2009
@sagetrac-drkirkby sagetrac-drkirkby mannequin assigned malb Nov 20, 2009
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Nov 23, 2009

comment:1

The lint errors were bought to the attention of Martin Albrecht when discussing #7375. He has said they will be addressed in due course, and have created a new ticket at

http://bitbucket.org/malb/m4ri/issue/18/cleanup-solaris-lint-warnings

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Nov 23, 2009

Upstream: Reported upstream. Developers acknowledge bug.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@jdemeyer
Copy link

comment:6

Obsolete and not really important anyway...

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer removed this from the sage-6.4 milestone Mar 13, 2015
@vbraun vbraun closed this as completed Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malb malb

Labels
c: packages: standard r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vbraun @malb @jdemeyer