Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numerical noise in doctests after pynac update #7609

Closed
burcin opened this issue Dec 6, 2009 · 7 comments
Closed

numerical noise in doctests after pynac update #7609

burcin opened this issue Dec 6, 2009 · 7 comments

Comments

@burcin
Copy link

burcin commented Dec 6, 2009

The new pynac package and patch from #7490 introduced numerical noise in some doctests. Attached patch should fix this.

Component: symbolics

Author: Burcin Erocal

Reviewer: Karl-Dieter Crisman

Merged: sage-4.3.rc0

Issue created by migration from https://trac.sagemath.org/ticket/7609

@burcin burcin added this to the sage-4.3 milestone Dec 6, 2009
@burcin burcin self-assigned this Dec 6, 2009
@burcin
Copy link
Author

burcin commented Dec 6, 2009

Attachment: trac_7609-pynac_numerical_noise.patch.gz

fix numerical noise

@kcrisman
Copy link
Member

kcrisman commented Dec 6, 2009

comment:2

This is fine, but there was another one in functions/trig.py (this on a 32-bit Macintel 10.5):

sage: float(cot(1))
0.64209261593433065

but gave

0.64209261593433076

@burcin
Copy link
Author

burcin commented Dec 6, 2009

apply only this patch

@burcin
Copy link
Author

burcin commented Dec 6, 2009

comment:3

Attachment: trac_7609-pynac_numerical_noise.take2.patch.gz

Hi Karl-Dieter,

attachment: trac_7609-pynac_numerical_noise.take2.patch adds a fix for the error you get as well. It is a good coincidence that you're testing on that box. :)

Thanks.

@burcin
Copy link
Author

burcin commented Dec 6, 2009

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

kcrisman commented Dec 7, 2009

comment:4

Okay, this seems good. I do still get the segfault in symbolic/expression.pyx but that is addressed elsewhere.

@mwhansen
Copy link
Contributor

mwhansen commented Dec 7, 2009

Merged: sage-4.3.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants