Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile, update MANIFEST.in, .hgignore, and spkg-related files #7784

Closed
williamstein opened this issue Dec 29, 2009 · 15 comments
Closed

Comments

@williamstein
Copy link
Contributor

Build-related cleanup.

CC: @sagetrac-mvngu @robert-marik

Component: notebook

Author: Mitesh Patel

Reviewer: Minh Van Nguyen

Merged: sagenb-0.7.3

Issue created by migration from https://trac.sagemath.org/ticket/7784

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Update .hgignore.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Author: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:1

Attachment: trac_7784-hgignore_update.patch.gz

In the patch, I've added setup.cfg and release_notes.txt and attempted to remove unnecessary entries. Please feel free to go further.

@qed777 qed777 mannequin added p: minor / 4 and removed p: major / 3 labels Jan 25, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:3

I think I should restore push and pull.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

Attachment: trac_7784-hgignore_update.2.patch.gz

Include pull and push. Replaces previous.

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 25, 2010

comment:4

Replying to @qed777:

I think I should restore push and pull.

V2 does this.

@qed777

This comment has been minimized.

@qed777 qed777 mannequin changed the title sagenb -- either include setup.cfg if it is human-written or put it in the .hgignore file Add Makefile, update MANIFEST.in, .hgignore, and spkg-related files Feb 1, 2010
@qed777 qed777 mannequin added t: bug and removed t: enhancement labels Feb 1, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 1, 2010

Attachment: trac_7784-sagenb_spkg_files.patch.gz

Add Makefile; update .hgignore and spkg-related files. Apply only this patch.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 1, 2010

comment:6

The new patch cleans up some build-related files. This "blocks" #8051.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 1, 2010

comment:7

I haven't decided yet what to do about release_notes.txt, so I haven't updated it. If we can auto-generate it, that would be great.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 1, 2010

comment:8

Replying to @qed777:

I haven't decided yet what to do about release_notes.txt, so I haven't updated it. If we can auto-generate it, that would be great.

I have been using the script at the following site to generate release notes for Sage:

http://bitbucket.org/mvngu/rnotes/

I think an option could be added to that script to generate release notes for sagenb. The current usage for the script is

./generate_release_notes sage-x.y.z

A possible option for generating sagenb specific release notes is

./generate_release_notes sage-x.y.z -sagenb

This would generate a release note for all sagenb specific tickets closed in the Sage x.y.z milestone. It's possible that during a particular milestone, more than one version of sagenb is released and integrated into Sage. Another possibility is

./generate_release_notes sagenb-x.y.z

This would generate a release note for sagenb x.y.z.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 1, 2010

comment:9

Thanks! I'll definitely take a closer look (though not immediately). I assume we'll make it separate ticket so we don't hold up this one.

@qed777 qed777 mannequin assigned qed777 and williamstein and unassigned williamstein and qed777 Feb 1, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

comment:11

Looks good to me. Apply the attachment trac_7784-sagenb_spkg_files.patch to sagenb-0.7.2.spkg under the directory sagenb-0.7.2/src/sagenb.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 3, 2010

Merged: sagenb-0.7.3

@qed777 qed777 mannequin removed the s: positive review label Feb 3, 2010
@qed777 qed777 mannequin closed this as completed Feb 3, 2010
@qed777 qed777 mannequin mentioned this issue Feb 10, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant