Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SASS files to MANIFEST.in #7937

Closed
qed777 mannequin opened this issue Jan 15, 2010 · 6 comments
Closed

Add SASS files to MANIFEST.in #7937

qed777 mannequin opened this issue Jan 15, 2010 · 6 comments
Assignees
@williamstein
Labels
c: user interface p: critical / 2 t: bug
Milestone
sage-4.3.1

Comments

@qed777
Copy link
Mannequin

qed777 mannequin commented Jan 15, 2010

The SASS source files from ticket #7269 are missing from sagenb-0.5.spkg:

hg stat
! sass/config.rb
! sass/readme.txt
! sass/src/account_settings.sass
! sass/src/main.sass
! sass/src/master.sass
! sass/src/partials/_mixins.sass
! sass/src/registration.sass
! sass/src/test_report.sass
! sass/src/typography/_base.sass
! sass/src/user_management.sass
? release_notes.txt
? setup.cfg

I think we just need to patch the MANIFEST.in.

CC: @TimDumol @williamstein

Component: notebook

Author: Mitesh Patel

Reviewer: Tim Dumol

Merged: sagenb-0.6

Issue created by migration from https://trac.sagemath.org/ticket/7937
@qed777 qed777 mannequin added this to the sage-4.3.1 milestone Jan 15, 2010
@qed777 qed777 mannequin added c: user interface labels Jan 15, 2010
@qed777 qed777 mannequin assigned williamstein Jan 15, 2010
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Jan 15, 2010

Updates MANIFEST.in for #7269. Does not include the missing files. sagenb repo.

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Jan 15, 2010

Author: Mitesh Patel

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Jan 15, 2010

comment:1

Attachment: trac_7937-sass_manifest.patch.gz

@qed777 qed777 mannequin added the s: needs review label Jan 15, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

comment:2

LGTM. Nice catch.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 19, 2010

Reviewer: Tim Dumol

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 19, 2010

Merged: sagenb-0.6

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: user interface p: critical / 2 t: bug
Projects
None yet
Milestone
sage-4.3.1
Development

No branches or pull requests
1 participant
@williamstein