Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning for popen3 in hg_sage #7967

Closed
wjp mannequin opened this issue Jan 17, 2010 · 5 comments
Closed

DeprecationWarning for popen3 in hg_sage #7967

wjp mannequin opened this issue Jan 17, 2010 · 5 comments
Labels
p: major / 3 t: bug
Milestone
sage-4.3.1

Comments

@wjp
Copy link
Mannequin

wjp mannequin commented Jan 17, 2010

Using hg_sage is raising a DeprecationWarning:

/data/sage/sage-4.3.1.rc0/local/lib/python2.6/site-packages/sage/misc/hg.py:240: DeprecationWarning: os.popen3 is deprecated.  Use the subprocess module.
  x = os.popen3(s)

Component: misc

Author: Willem Jan Palenstijn

Reviewer: Tim Dumol

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7967
@wjp wjp mannequin added p: major / 3 labels Jan 17, 2010
@wjp wjp mannequin added this to the sage-4.3.1 milestone Jan 17, 2010
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

Reviewer: Tim Dumol

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

Author: Willem Palenstijn

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jan 17, 2010

comment:2

Attachment: 7967_popen3.patch.gz

Good job; looks good.

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 19, 2010

Merged: sage-4.3.1.rc1

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
@fchapoton
Copy link
Contributor

Changed author from Willem Palenstijn to Willem Jan Palenstijn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3.1
Development

No branches or pull requests
1 participant
@fchapoton