Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation related to ODE solvers #8132

Closed
robert-marik mannequin opened this issue Jan 31, 2010 · 12 comments
Closed

fix documentation related to ODE solvers #8132

robert-marik mannequin opened this issue Jan 31, 2010 · 12 comments

Comments

@robert-marik
Copy link
Mannequin

robert-marik mannequin commented Jan 31, 2010

The documentation to ODE solvers is not written in harmony with Sage developers guide and the Sage Constructions are outdated.

Component: documentation

Author: Robert Mařík

Reviewer: David Joyner

Merged: sage-4.3.2.rc0

Issue created by migration from https://trac.sagemath.org/ticket/8132

@robert-marik robert-marik mannequin added this to the sage-4.3.2 milestone Jan 31, 2010
@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

Attachment: trac_8132.patch.gz

@robert-marik robert-marik mannequin added the s: needs review label Jan 31, 2010
@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

comment:2

this patch

  • fixes indentation in sage/gsl/ode.pyx from 3 spaces to 4 spaces

  • fixes documentation

@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

Attachment: trac_8132_fixed_doctests.patch.gz

fixes one failed doctest, apply on the top of previous poatch

@wdjoyner
Copy link

comment:3

This seems to be an excellent and extremely welcomed collection of docstring fixes related to solving differential equations in Sage.

Am I missing something or is it odd that calculus/desolver is not listed http://www.sagemath.org/doc/reference/modindex.html? Using
http://www.sagemath.org/doc/developer/sage_manuals.html#building-the-manuals
I see how to rebuild the manual but how do I see what the changes in the patch look like if
desolver isn't even in the manual in the first place?

Can a patch be added to include desolver in the manual?

@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

comment:4

Fixed thanks. Thanks for the links how to do it.
Two new chapters are at the end of Symbolic Calculus.

PDF manual does not build, partly due to #8036, patly due to another problem not related to this ticket (unknown command \cross used in some file related to polynomials). The ODE part of PDF manual looks good, anyway.

Html version looks good for me.

@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

apply on the top of the previous two patches

@robert-marik
Copy link
Mannequin Author

robert-marik mannequin commented Jan 31, 2010

comment:5

Attachment: trac_8132_fixed_reference_manual.patch.gz

btw: the second problem which caused pdf not to build has been fixed by #8021

@wdjoyner
Copy link

comment:6

Three patches apply fine to 4.3.2.a0 and passes sage -testall, except for apparently unrelated failures already reported, on a mac 10.6.2.

Very nice docstring patch Robert!

Positive review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

comment:7

Merged in the following order:

  1. trac_8132.patch
  2. trac_8132_fixed_doctests.patch
  3. trac_8132_fixed_reference_manual.patch

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

Reviewer: David Joyner

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

Merged: sage-4.3.2.rc0

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

Author: Robert Mařík

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant