Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building HTML version of French tutorial is broken #8146

Closed
sagetrac-mvngu mannequin opened this issue Feb 2, 2010 · 6 comments
Closed

building HTML version of French tutorial is broken #8146

sagetrac-mvngu mannequin opened this issue Feb 2, 2010 · 6 comments

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 2, 2010

Ticket #8036 fixes some issues with non-ASCII characters in the reference manual. But it breaks the building of the HTML version of the French tutorial:

sphinx-build -b html -d /scratch/mvngu/release/sage-4.3.2.alpha1/devel/sage/doc/output/doctrees/fr/tutorial    /scratch/mvngu/release/sage-4.3.2.alpha1/devel/sage/doc/fr/tutorial /scratch/mvngu/release/sage-4.3.2.alpha1/devel/sage/doc/output/html/fr/tutorial
Running Sphinx v0.6.3

Exception occurred:
  File "/scratch/mvngu/release/sage-4.3.2.alpha1/devel/sage/doc/fr/tutorial/conf.py", line 38, in <module>
    latex_preamble += '\\DeclareUnicodeCharacter{00A0}{\\nobreakspace}\n'
NameError: name 'latex_preamble' is not defined
The full traceback has been saved in /tmp/sphinx-err-6XQBIT.log, if you want to report the issue to the author.
Please also report this if it was a user error, so that a better error message can be provided next time.
Send reports to sphinx-dev@googlegroups.com. Thanks!
Build finished.  The built documents can be found in /scratch/mvngu/release/sage-4.3.2.alpha1/devel/sage/doc/output/html/fr/tutorial

This is due to the deletion of the line

latex_preamble = '\usepackage{amsmath}\n\usepackage{amsfonts}\n' 

in trac_8036-docbuild_utf8x.patch. I'm making this a blocker against Sage 4.3.2.

CC: @qed777

Component: documentation

Keywords: French tutorial

Author: John Palmieri

Reviewer: Mitesh Patel

Merged: sage-4.3.2.rc0

Issue created by migration from https://trac.sagemath.org/ticket/8146

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.3.2 milestone Feb 2, 2010
@sagetrac-mvngu sagetrac-mvngu mannequin self-assigned this Feb 2, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 2, 2010

comment:1

We need to upgrade SAGE_DOC/fr/tutorial/conf.py to use latex_elements['preamble'] instead of latex_preamble, which is deprecated. I'll check the other documents.

@jhpalmieri
Copy link
Member

comment:2

If I either delete the last few lines of SAGE_DOC/fr/tutorial/conf.py -- the ones dealing with latex_preamble -- or if I replace them with lines using latex_elements['preamble'] instead, the build seems to go through either way. I suppose the second option is closer to what we have now, so we should use that? Here's a patch.

@jhpalmieri
Copy link
Member

comment:3

Attachment: trac_8146-french.patch.gz

(I didn't check conf.py for the other documents, but they build with just the usual warnings, so I don't think we need to modify them.)

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 2, 2010

Reviewer: Mitesh Patel

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 2, 2010

Author: John Palmieri

@qed777 qed777 mannequin added s: positive review and removed s: needs review labels Feb 2, 2010
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Feb 2, 2010

Merged: sage-4.3.2.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant