Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix another doctest in base.pyx #8235

Closed
sagetrac-wcauchois mannequin opened this issue Feb 11, 2010 · 8 comments
Closed

fix another doctest in base.pyx #8235

sagetrac-wcauchois mannequin opened this issue Feb 11, 2010 · 8 comments
Assignees
@aghitza
Labels
c: graphics p: minor / 4 t: bug
Milestone
sage-4.3.3

Comments

@sagetrac-wcauchois
Copy link
Mannequin

sagetrac-wcauchois mannequin commented Feb 11, 2010

This ticket is related to #7985. There's another doctest in base.pyx (on line 1308) that uses the output of texture_set(), which is inconsistent across machines since the order of Texture objects in a set is not well defined. This should be a trivial fix.

Related: #2872. 

Component: graphics

Author: Bill Cauchois

Reviewer: Mitesh Patel

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8235
@sagetrac-wcauchois
Copy link
Mannequin Author

sagetrac-wcauchois mannequin commented Feb 11, 2010

based on sage 4.3.1

@sagetrac-wcauchois
Copy link
Mannequin Author

sagetrac-wcauchois mannequin commented Feb 11, 2010

comment:1

Attachment: trac_8235.patch.gz

Its not terribly pretty, but this should fix it.

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

Author: Bill Cauchois

@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

Reviewer: Mitesh Patel

@qed777 qed777 mannequin added this to the sage-4.3.3 milestone Feb 11, 2010
@qed777 qed777 mannequin added p: minor / 4 and removed p: major / 3 labels Feb 11, 2010
@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

comment:3

Running sage -t plot/plot3d/base.pyx 10 or so times in succession yields no failures. Positive review.

Please remember to set / update the relevant ticket fields.

Thanks!

@qed777

This comment has been minimized.

Sign in to view
@qed777

This comment has been minimized.

Sign in to view
@qed777
Copy link
Mannequin

qed777 mannequin commented Feb 11, 2010

Merged: sage-4.3.3.alpha0

@qed777 qed777 mannequin removed the s: positive review label Feb 11, 2010
@qed777 qed777 mannequin closed this as completed Feb 11, 2010
@williamstein williamstein mentioned this issue Feb 11, 2010
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: graphics p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.3.3
Development

No branches or pull requests
1 participant
@aghitza