make iconv a prerequisite for building gd

[sagetrac-mvngu]

From sage-release:

As expected based on my experience with 4.3.3, I got a build error
building 4.3.4.alpha0, though this time it was a linking error with gd
rather than cddlib. Again, this is Fedora 10 on a 64-bit system, but
on a 32-bit network, so there exist 32-bit libraries findable via NFS
(under /usr/local). But this time I don't see any obvious evidence
that this is the source of the trouble.
-----
/bin/sh ./libtool --tag=CC --mode=link gcc  -fPIC -g -I"/scratch/
sage-4.3.4.alph
a0/local/include" -I/scratch/sage-4.3.4.alpha0/local/include/
freetype2/  -L/scra
tch/sage-4.3.4.alpha0/local/lib -Wl,--rpath -Wl,/scratch/
sage-4.3.4.alpha0/local
/lib  -L/scratch/sage-4.3.4.alpha0/local/lib  -o annotate
annotate.o ./libgd.la
 -lfontconfig -lfreetype -lpng12 -lz -lm
gcc -fPIC -g -I/scratch/sage-4.3.4.alpha0/local/include -I/scratch/
sage-4.3.4.al
pha0/local/include/freetype2/ -Wl,--rpath -Wl,/scratch/
sage-4.3.4.alpha0/local/l
ib -o .libs/annotate annotate.o  -L/scratch/sage-4.3.4.alpha0/local/
lib ./.libs/
libgd.so -lfontconfig /scratch/sage-4.3.4.alpha0/local/lib/
libfreetype.so /scrat
ch/sage-4.3.4.alpha0/local/lib/libpng12.so -lz -lm -Wl,--rpath -Wl,/
scratch/sage
-4.3.4.alpha0/local/lib
./.libs/libgd.so: undefined reference to `libiconv'
./.libs/libgd.so: undefined reference to `libiconv_close'
./.libs/libgd.so: undefined reference to `libiconv_open'
collect2: ld returned 1 exit status

This is due to gd being built before iconv. mpatel suggested at #8191 to make iconv a dependency for building gd. See also #8306 which implements this dependency rule.

Component: packages: standard

Author: Minh Van Nguyen

Reviewer: David Kirkby

Merged: sage-4.3.4.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/8432

[sagetrac-mvngu]

differences between deps in Sage 4.3.4.alpha0 and updated deps

[sagetrac-mvngu]

Attachment: deps.diff.gz

updated deps

[sagetrac-mvngu]

comment:1

Attachment: deps.gz

[sagetrac-mvngu]

comment:2

You should replace the current file SAGE_ROOT/spkg/standard/deps in Sage 4.3.4.alpha0 with the updated one on this ticket, i.e. deps.

[sagetrac-drkirkby]

comment:3

I'll make a patch for that. Sorry, I overlooked the importance of this. I'm still somewhat puzzled how it ever built on Fedora if it needs an iconv - unless gd has been recently updated to need iconv too.

There is, as yet an untested file on 't2'

/rootpool2/local/kirkby/sage-4.3.4.alpha0.Solaris-untested.tar

which has

• sage-4.3.4.alpha0 source
• All the patches list at Fix build and doctest issues for Solaris 10 (SPARC) in 32-bit mode. #8409 applied
• This item addressed.

That may or may not build on 't2', but if it does, it should have all known bug fixes that allow all doctests (including the long ones) to pass.

Dave

[sagetrac-drkirkby]

comment:4

Sorry, I forgot to preview my previous post. I'll make it again.

I'll make a patch for this bug. Sorry, I overlooked the importance of this. I'm still somewhat puzzled how gd ever built on Fedora if it needs an iconv - unless gd has been recently updated to need iconv too.

There is, as yet an untested file on 't2'

/rootpool2/local/kirkby/sage-4.3.4.alpha0.Solaris-untested.tar

which has

• sage-4.3.4.alpha0 source
• All the patches list at Fix build and doctest issues for Solaris 10 (SPARC) in 32-bit mode. #8409 applied
• This item addressed.

That may or may not build on 't2', but if it does, it should have all known bug fixes that allow all doctests (including the long ones) to pass.

Dave

[sagetrac-drkirkby]

comment:5

I realise I can't make a patch for this, as this is not under revision control. But I can give it a positive review. Minh will have to integrate this manually.

[mwhansen]

Author: Minh Van Nguyen

[mwhansen]

Reviewer: David Kirkby

[mwhansen]

Merged: sage-4.3.4.alpha1