-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frobby optional spkg doesn't build with newer GCC's #8783
Comments
Upstream: Reported upstream. Little or no feedback. |
comment:2
Note that this still builds on sage.math with GCC-4.2.4... But it doesn't build on Skynet with newer GCC's. |
Changed upstream from Reported upstream. Little or no feedback. to Fixed upstream, in a later stable release. |
comment:3
|
comment:4
|
comment:5
Note, gcc 4.5 is not the latest gcc, but gcc 4.4.4 is: See
Dave |
comment:6
Even with gcc-4.4.3, Frobby doesn't build. If somebody doesn't post a new frobby spkg on this ticket for review this week, I'm moving the frobby spkg to "experimental". -- William |
comment:7
Replying to @williamstein:
I wish you would clarify in the developers handbook, or even just on sage-devel, what is the difference between "optional" and "experimental". Dave |
comment:8
I have moved Frobby from optional to experimental. I'll move it back when this problem is addressed. |
comment:9
I've had some problems on this because I don't have access to a computer that both has Sage on it and that at the same time has a recent enough version of GCC that this issue comes up. What I've done is patch the spkg so that the Frobby code in it compiles on a Cygwin machine I've got, and then I've tested that it still installs on sage.math, which I've recently gotten access to. So if we are lucky this will work, though someone with both Sage and a recent version of gcc should check it. I put the spkg here: http://sage.math.washington.edu/home/bjarke/frobby-0.7.6.p1.spkg |
comment:10
I looked at this for 1 minute: (1)
(2) The hg repo has lots of files that have been added but not checked in:
(3) I don't understand why upstream -- i.e., the author of frobby-- is adding a ton of patches to his own code. Why not just fix the src/ directly? |
comment:11
That said, Frobby does build with GCC-4.5.0, which is great news!!
|
This comment has been minimized.
This comment has been minimized.
comment:13
(Oops, I put my response as the description. Now fixed.) Thanks for the prompt review. I committed the outstanding files in the repository and removed the two ~ files. The result is up in the same place: http://sage.math.washington.edu/home/bjarke/frobby-0.7.6.p1.spkg I'm adding patches rather than edit src/ because as I understand it the code in src/ must be an official release of the upstream code. No version 0.7.6 of Frobby exists that compiles under gcc 4.3.0, and I'd rather add some patches here than make an official release of an old version. |
This comment has been minimized.
This comment has been minimized.
Reviewer: Benjamin Jones |
comment:14
I can verify that the ~ files were removed and the repository is clean. The SPKG successfully builds using GCC 4.4.5. I'm trying GCC 4.5.? now. |
comment:15
The SPKG builds using GCC 4.6.1 as well. Here is the build log: https://gist.github.com/1164148 Unless anyone has further comments / concerns, I will give the new SPKG a positive review. |
Author: Bjarke Hammersholt Roune |
This comment has been minimized.
This comment has been minimized.
Changed keywords from none to sd32 |
This comment has been minimized.
This comment has been minimized.
comment:20
Did anybody try to build this with I get hundreds of errors on Ubuntu 10.04.3 (GCC 4.4.3). The build itself succeeds, but the test suite ends with:
The main problem seems a wrong or missing include path, which of course causes further errors. |
Build with |
comment:21
Attachment: frobby-0.7.6.p1-redhawk-SAGE_CHECK.log Ooops, should read 4.4.3, but the version shouldn't matter much anyway... ;-) (Attached the build log.) |
comment:22
I didn't run the build with SAGE_CHECK=yes when I reviewed the package, but I did run the test suite manually. This was on skynet/eno which has GCC 4.6.1 installed. I just ran the build under Sage 4.7.2.alpha1 on skynet/eno using |
Attachment: frobby_build_4.7.2.alpha1.eno.log frobby build log with SAGE_CHECK=yes on skynet/eno |
comment:23
Ping. |
comment:24
Closing as a duplicate in light of #13007. |
Changed reviewer from Benjamin Jones to Benjamin Jones, Bjarke Hammersholt Roune |
Changed author from Bjarke Hammersholt Roune to none |
New optional spkg: http://sage.math.washington.edu/home/bjarke/frobby-0.7.6.p1.spkg
The spkg has to be brought into place to "merge" it.
Upstream: Fixed upstream, in a later stable release.
Component: packages: optional
Keywords: sd32
Reviewer: Benjamin Jones, Bjarke Hammersholt Roune
Issue created by migration from https://trac.sagemath.org/ticket/8783
The text was updated successfully, but these errors were encountered: