-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.{geometry,rings}
: More # optional
tags in doctests
#35136
sage.{geometry,rings}
: More # optional
tags in doctests
#35136
Conversation
Codecov ReportBase: 88.58% // Head: 88.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35136 +/- ##
===========================================
- Coverage 88.58% 88.45% -0.13%
===========================================
Files 2140 2140
Lines 396998 397009 +11
===========================================
- Hits 351676 351187 -489
- Misses 45322 45822 +500
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failing tests, which makes me wonder whether # optional - sage.libs.pari
is working at all.
Indeed the optional tag was not working, fixed now. |
…oups, sage.plot, sage.rings.number_field, sage.symbolic
…, sage.rings.number_field, sage.symbolic
…viewer fixes to # optional tags
17dba77
to
4aa6264
Compare
Thank you! |
Documentation preview for this PR is ready! 🎉 |
📚 Description
Adding more
# optional
tags in doctests so that doctests can be run with modularized distributions.📝 Checklist
⌛ Dependencies