Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.{geometry,rings}: More # optional tags in doctests #35136

Merged
merged 9 commits into from
Mar 26, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 15, 2023

📚 Description

Adding more # optional tags in doctests so that doctests can be run with modularized distributions.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 88.58% // Head: 88.45% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (02f15b2) compared to base (05329f6).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35136      +/-   ##
===========================================
- Coverage    88.58%   88.45%   -0.13%     
===========================================
  Files         2140     2140              
  Lines       396998   397009      +11     
===========================================
- Hits        351676   351187     -489     
- Misses       45322    45822     +500     
Impacted Files Coverage Δ
src/sage/geometry/cone_catalog.py 100.00% <ø> (ø)
...geometry/hyperplane_arrangement/affine_subspace.py 98.24% <ø> (ø)
src/sage/geometry/linear_expression.py 96.95% <ø> (ø)
src/sage/geometry/polyhedral_complex.py 24.21% <ø> (-72.33%) ⬇️
...c/sage/geometry/polyhedron/backend_number_field.py 100.00% <ø> (ø)
src/sage/geometry/polyhedron/base.py 93.20% <ø> (ø)
src/sage/geometry/polyhedron/base2.py 95.31% <ø> (ø)
src/sage/geometry/polyhedron/base5.py 93.17% <ø> (ø)
src/sage/geometry/polyhedron/base6.py 92.00% <ø> (ø)
src/sage/geometry/polyhedron/base7.py 46.22% <0.00%> (-0.48%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kliem kliem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failing tests, which makes me wonder whether # optional - sage.libs.pari is working at all.

src/sage/geometry/polyhedron/base2.py Outdated Show resolved Hide resolved
src/sage/rings/integer.pyx Outdated Show resolved Hide resolved
src/sage/rings/integer.pyx Outdated Show resolved Hide resolved
src/sage/rings/integer.pyx Outdated Show resolved Hide resolved
src/sage/rings/integer.pyx Outdated Show resolved Hide resolved
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 15, 2023

Indeed the optional tag was not working, fixed now.

@mkoeppe mkoeppe force-pushed the sage_geometry_more_optional_tags branch from 17dba77 to 4aa6264 Compare February 17, 2023 05:20
@mkoeppe mkoeppe self-assigned this Feb 18, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2023

Thank you!

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 02f15b2

@vbraun vbraun merged commit b6b5c2c into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants