-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.matrix.operation_table
: Modularization and code style fixes
#35153
sage.matrix.operation_table
: Modularization and code style fixes
#35153
Conversation
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35153 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2140 2140
Lines 396961 396958 -3
===========================================
- Hits 351677 351656 -21
- Misses 45284 45302 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few trivial doc formatting things. LGTM otherwise.
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Thank you! I've committed these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Documentation preview for this PR is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@Bruno-TT - who wrote that graphic tables code - might want to have a look, but I guess it's all right.
Thanks, Dima! |
📚 Description
We remove the module-level dependency of
sage.matrix.operation_table
onmatplotlib
andsage.plot
and fix some code style issues.It fixes a modularization regression introduced in #8598.
📝 Checklist
⌛ Dependencies