-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many more namespace packages – follow up #35366
Merged
vbraun
merged 16 commits into
sagemath:develop
from
mkoeppe:many_more_namespace_packages_2
Apr 6, 2023
Merged
Many more namespace packages – follow up #35366
vbraun
merged 16 commits into
sagemath:develop
from
mkoeppe:many_more_namespace_packages_2
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py files are present
…namespacification
…terpreters as a namespace package
Work item: Add comments to the new |
tornaria
approved these changes
Apr 4, 2023
I tested this as explained in #35322 (comment). No harmful interaction with system sagemath. I also had a look at the patch and it LGTM. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Follow-up from #35322.
📝 Checklist
⌛ Dependencies