Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial #36476

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial #36476

merged 1 commit into from
Oct 21, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 17, 2023 •
edited
Loading

On centos-7, still supported until June 2024, we have to use sage-bootstrap-python = python2.
Support for Python 2 was broken accidentally in #36393, see https://github.com/sagemath/sage/actions/runs/6520548150/job/17767608828#step:10:1927

Fixed here, as tested with tox -e docker-centos-7-devtoolset-gcc_11-standard -- config.status.

Same issue also affects fedora-30, which is still tested by the CI as a proxy for old RHEL, and ubuntu-xenial. See #32074

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Oct 17, 2023
@mkoeppe mkoeppe changed the title Fix bootstrapping on centos-7, fedora-30 Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial Oct 17, 2023
@mkoeppe mkoeppe requested a review from dimpase October 17, 2023 18:20
tobiasdiez
tobiasdiez approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well (the macos conda workflow had the same issue, but bootstrap is working there now).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 19, 2023

Thanks!

@vbraun vbraun merged commit c47788b into sagemath:develop Oct 21, 2023
23 of 30 checks passed
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@dimpase dimpase Awaiting requested review from dimpase

Assignees

@mkoeppe mkoeppe

Labels
c: scripts p: critical / 2
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @tobiasdiez @vbraun