Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/sage-conf_pypi: Repair after #36400, #36435 #36533

Merged
merged 11 commits into from
Nov 10, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 24, 2023

This repairs the installation method described in https://github.com/sagemath/sage#alternative-installation-using-pypi broken by changes in #36400, #36435.

We also expand the tests for this distribution in its tox.ini.
Run (cd pkgs/sage-conf_pypi && tox -v -v -e py311)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 2, 2023

Let's get this in please for 10.2

@mkoeppe mkoeppe requested a review from jhpalmieri November 4, 2023 18:19
@mkoeppe mkoeppe force-pushed the sage_conf_pypi_fix branch from 52f47e0 to 1f30d72 Compare November 4, 2023 21:49
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 4, 2023

rebased away from #36523

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 6, 2023

I followed the instructions of https://github.com/sagemath/sage#alternative-installation-using-pypi. I got

$ python3 -m pip install sagemath-standard
WARNING: Skipping /usr/local/lib/python3.11/site-packages/numpy-1.26.1-py3.11.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/packaging-23.2.dist-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/numpy-1.26.1-py3.11.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/packaging-23.2.dist-info due to invalid metadata entry 'name'
Collecting sagemath-standard
  Using cached sagemath-standard-10.1.tar.gz (19.2 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      Error in sitecustomize; set PYTHONVERBOSE for traceback:
      AssertionError:
      Traceback (most recent call last):
        File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
          main()
        File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/usr/local/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/setuptools/build_meta.py", line 338, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/local/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/setuptools/build_meta.py", line 320, in _get_build_requires
          self.run_setup()
        File "/usr/local/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/setuptools/build_meta.py", line 335, in run_setup
          exec(code, locals())
        File "<string>", line 42, in <module>
      ModuleNotFoundError: No module named 'sage_setup'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
WARNING: Skipping /usr/local/lib/python3.11/site-packages/numpy-1.26.1-py3.11.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/packaging-23.2.dist-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/numpy-1.26.1-py3.11.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.11/site-packages/packaging-23.2.dist-info due to invalid metadata entry 'name'
WARNING: There was an error checking the latest version of pip.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 6, 2023

With this PR, I got

$ (cd pkgs/sage-conf_pypi && tox)
python: install_deps> python -I -m pip install sagemath-environment
ERROR: Ignored the following versions that require a different python version: 10.0 Requires-Python <3.12,>=3.8; 10.0b0 Requires-Python <3.12,>=3.8; 10.0b1 Requires-Python <3.12,>=3.8; 10.0b2 Requires-Python <3.12,>=3.8; 10.0b4 Requires-Python <3.12,>=3.8; 10.0b5 Requires-Python <3.12,>=3.8; 10.0b6 Requires-Python <3.12,>=3.8; 10.0b7 Requires-Python <3.12,>=3.8; 10.0b8 Requires-Python <3.12,>=3.8; 10.0b9 Requires-Python <3.12,>=3.8; 10.0rc0 Requires-Python <3.12,>=3.8; 10.0rc1 Requires-Python <3.12,>=3.8; 10.0rc2 Requires-Python <3.12,>=3.8; 10.0rc3 Requires-Python <3.12,>=3.8; 10.1 Requires-Python <3.12,>=3.8; 10.1b0 Requires-Python <3.12,>=3.8; 10.1b1 Requires-Python <3.12,>=3.8; 10.1b2 Requires-Python <3.12,>=3.8; 10.1b3 Requires-Python <3.12,>=3.8; 10.1b4 Requires-Python <3.12,>=3.8; 10.1b5 Requires-Python <3.12,>=3.8; 10.1b6 Requires-Python <3.12,>=3.8; 10.1b7 Requires-Python <3.12,>=3.8; 10.1b9 Requires-Python <3.12,>=3.8; 10.1rc0 Requires-Python <3.12,>=3.8; 10.2b0 Requires-Python <3.12,>=3.9; 10.2b1 Requires-Python <3.12,>=3.9; 10.2b2 Requires-Python <3.12,>=3.9; 10.2b3 Requires-Python <3.12,>=3.9; 10.2b4 Requires-Python <3.12,>=3.9; 10.2b5 Requires-Python <3.12,>=3.9; 10.2b6 Requires-Python <3.12,>=3.9; 10.2b7 Requires-Python <3.12,>=3.9; 10.2b8 Requires-Python <3.12,>=3.9; 10.2b9 Requires-Python <3.12,>=3.9; 10.2rc0 Requires-Python <3.12,>=3.9; 9.5b7 Requires-Python <3.10,>=3.7; 9.5b7.post1 Requires-Python <3.10,>=3.7; 9.5b7.post2 Requires-Python <3.10,>=3.7; 9.5b7.post3 Requires-Python <3.10,>=3.7; 9.5b7.post4 Requires-Python <3.10,>=3.7; 9.5b8 Requires-Python <3.11,>=3.7; 9.6rc3 Requires-Python <3.11,>=3.7; 9.6rc3.post2 Requires-Python <3.11,>=3.7; 9.7 Requires-Python <3.11,>=3.7; 9.7b3 Requires-Python <3.11,>=3.7; 9.7b4 Requires-Python <3.11,>=3.7; 9.7b5 Requires-Python <3.11,>=3.7; 9.7b6 Requires-Python <3.11,>=3.7; 9.7b7 Requires-Python <3.11,>=3.7; 9.7b8 Requires-Python <3.11,>=3.7; 9.7rc0 Requires-Python <3.11,>=3.7; 9.7rc1 Requires-Python <3.11,>=3.7; 9.7rc2 Requires-Python <3.11,>=3.7; 9.8 Requires-Python <3.12,>=3.8; 9.8b0 Requires-Python <3.11,>=3.7; 9.8b1 Requires-Python <3.11,>=3.7; 9.8b2 Requires-Python <3.11,>=3.7; 9.8b3 Requires-Python <3.11,>=3.7; 9.8b4 Requires-Python <3.11,>=3.7; 9.8b5 Requires-Python <3.11,>=3.7; 9.8b6 Requires-Python <3.11,>=3.7; 9.8b7 Requires-Python <3.12,>=3.8; 9.8rc0 Requires-Python <3.12,>=3.8
ERROR: Could not find a version that satisfies the requirement sagemath-environment (from versions: none)
ERROR: No matching distribution found for sagemath-environment

python: exit 1 (1.19 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi> python -I -m pip install sagemath-environment pid=80710
python: FAIL ✖ in 1.2 seconds
python-user: install_deps> env PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python-user/bin python -I -m pip install --user sagemath-environment
WARNING: Skipping /usr/local/lib/python3.12/site-packages/numpy-1.26.1-py3.12.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.12/site-packages/numpy-1.26.1-py3.12.egg-info due to invalid metadata entry 'name'
WARNING: Skipping /usr/local/lib/python3.12/site-packages/packaging-23.2.dist-info due to invalid metadata entry 'name'
ERROR: Ignored the following versions that require a different python version: 10.0 Requires-Python <3.12,>=3.8; 10.0b0 Requires-Python <3.12,>=3.8; 10.0b1 Requires-Python <3.12,>=3.8; 10.0b2 Requires-Python <3.12,>=3.8; 10.0b4 Requires-Python <3.12,>=3.8; 10.0b5 Requires-Python <3.12,>=3.8; 10.0b6 Requires-Python <3.12,>=3.8; 10.0b7 Requires-Python <3.12,>=3.8; 10.0b8 Requires-Python <3.12,>=3.8; 10.0b9 Requires-Python <3.12,>=3.8; 10.0rc0 Requires-Python <3.12,>=3.8; 10.0rc1 Requires-Python <3.12,>=3.8; 10.0rc2 Requires-Python <3.12,>=3.8; 10.0rc3 Requires-Python <3.12,>=3.8; 10.1 Requires-Python <3.12,>=3.8; 10.1b0 Requires-Python <3.12,>=3.8; 10.1b1 Requires-Python <3.12,>=3.8; 10.1b2 Requires-Python <3.12,>=3.8; 10.1b3 Requires-Python <3.12,>=3.8; 10.1b4 Requires-Python <3.12,>=3.8; 10.1b5 Requires-Python <3.12,>=3.8; 10.1b6 Requires-Python <3.12,>=3.8; 10.1b7 Requires-Python <3.12,>=3.8; 10.1b9 Requires-Python <3.12,>=3.8; 10.1rc0 Requires-Python <3.12,>=3.8; 10.2b0 Requires-Python <3.12,>=3.9; 10.2b1 Requires-Python <3.12,>=3.9; 10.2b2 Requires-Python <3.12,>=3.9; 10.2b3 Requires-Python <3.12,>=3.9; 10.2b4 Requires-Python <3.12,>=3.9; 10.2b5 Requires-Python <3.12,>=3.9; 10.2b6 Requires-Python <3.12,>=3.9; 10.2b7 Requires-Python <3.12,>=3.9; 10.2b8 Requires-Python <3.12,>=3.9; 10.2b9 Requires-Python <3.12,>=3.9; 10.2rc0 Requires-Python <3.12,>=3.9; 9.5b7 Requires-Python <3.10,>=3.7; 9.5b7.post1 Requires-Python <3.10,>=3.7; 9.5b7.post2 Requires-Python <3.10,>=3.7; 9.5b7.post3 Requires-Python <3.10,>=3.7; 9.5b7.post4 Requires-Python <3.10,>=3.7; 9.5b8 Requires-Python <3.11,>=3.7; 9.6rc3 Requires-Python <3.11,>=3.7; 9.6rc3.post2 Requires-Python <3.11,>=3.7; 9.7 Requires-Python <3.11,>=3.7; 9.7b3 Requires-Python <3.11,>=3.7; 9.7b4 Requires-Python <3.11,>=3.7; 9.7b5 Requires-Python <3.11,>=3.7; 9.7b6 Requires-Python <3.11,>=3.7; 9.7b7 Requires-Python <3.11,>=3.7; 9.7b8 Requires-Python <3.11,>=3.7; 9.7rc0 Requires-Python <3.11,>=3.7; 9.7rc1 Requires-Python <3.11,>=3.7; 9.7rc2 Requires-Python <3.11,>=3.7; 9.8 Requires-Python <3.12,>=3.8; 9.8b0 Requires-Python <3.11,>=3.7; 9.8b1 Requires-Python <3.11,>=3.7; 9.8b2 Requires-Python <3.11,>=3.7; 9.8b3 Requires-Python <3.11,>=3.7; 9.8b4 Requires-Python <3.11,>=3.7; 9.8b5 Requires-Python <3.11,>=3.7; 9.8b6 Requires-Python <3.11,>=3.7; 9.8b7 Requires-Python <3.12,>=3.8; 9.8rc0 Requires-Python <3.12,>=3.8
ERROR: Could not find a version that satisfies the requirement sagemath-environment (from versions: none)
ERROR: No matching distribution found for sagemath-environment

python-user: exit 1 (1.18 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi> env PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python-user/bin python -I -m pip install --user sagemath-environment pid=80714
  python: FAIL code 1 (1.20 seconds)
  python-user: FAIL code 1 (1.20 seconds)
  evaluation failed :( (2.67 seconds)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 6, 2023

Looks like your system Python is 3.12 already. That won't work because sagemath-environment (like all of our distributions) still declares "python-requires < 3.12".

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 6, 2023

My system python is python 3.11, which is at /ust/local/bin/python

I added this to tox.ini

[testenv]
basepython=/usr/local/bin/python   

and ran (cd pkgs/sage-conf_pypi && tox) again and got

$ (cd pkgs/sage-conf_pypi && tox)
.pkg-cpython311: _optional_hooks> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg-cpython311: get_requires_for_build_wheel> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg-cpython311: build_wheel> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
python: install_package> python -I -m pip install --force-reinstall --no-deps /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.tmp/package/6/sage_conf-10.2rc0-py3-none-any.whl
python: commands[0]> bash -c 'set -ex; eval $SETENV; sage-config; ls $(sage-config SAGE_SPKG_WHEELS); sage -sh -c "frobby genideal"; /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python/bin/python -m pip install $(sage-config SAGE_SPKG_WHEELS)/*.whl'
+ eval
+ sage-config
VERSION=10.2.rc0
SAGE_LOCAL=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local
SAGE_ROOT=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64
MAXIMA=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/bin/maxima
MAXIMA_FAS=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/lib/ecl/maxima.fas
KENZO_FAS=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/lib/ecl/kenzo.fas
ARB_LIBRARY=arb
NTL_INCDIR=///usr/local/opt/ntl/include
NTL_LIBDIR=///usr/local/opt/ntl/lib
ECL_CONFIG=/usr/local/bin/ecl-config
SAGE_NAUTY_BINS_PREFIX=
FOURTITWO_HILBERT=hilbert
FOURTITWO_MARKOV=markov
FOURTITWO_GRAVER=graver
FOURTITWO_ZSOLVE=zsolve
FOURTITWO_QSOLVE=qsolve
FOURTITWO_RAYS=rays
FOURTITWO_PPI=ppi
FOURTITWO_CIRCUITS=circuits
FOURTITWO_GROEBNER=groebner
CBLAS_PC_MODULES=cblas
SAGE_ARCHFLAGS=unset
SAGE_PKG_CONFIG_PATH=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/lib/pkgconfig
MATHJAX_DIR=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/share/mathjax/mathjax
THREEJS_DIR=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/share/threejs-sage
OPENMP_CFLAGS=
OPENMP_CXXFLAGS=
SAGE_SPKG_WHEELS=/Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/var/lib/sage/venv-python3.11/var/lib/sage/wheels
++ sage-config SAGE_SPKG_WHEELS
+ ls /Users/kwankyu/.sage/sage-10.2.rc0-Darwin-x86_64/local/var/lib/sage/venv-python3.11/var/lib/sage/wheels
Babel-2.12.1-py3-none-any.whl
Cython-3.0.4-cp311-cp311-macosx_12_0_x86_64.whl
Jinja2-3.1.2-py3-none-any.whl
MarkupSafe-2.1.3-cp311-cp311-macosx_12_0_x86_64.whl
Pillow-10.0.1-cp311-cp311-macosx_12_0_x86_64.whl
Pygments-2.13.0-py3-none-any.whl
alabaster-0.7.12-py2.py3-none-any.whl
appnope-0.1.3-py2.py3-none-any.whl
asttokens-2.1.0-py2.py3-none-any.whl
attrs-23.1.0-py3-none-any.whl
backcall-0.2.0-py2.py3-none-any.whl
beniget-0.4.1-py3-none-any.whl
calver-2022.6.26-py3-none-any.whl
certifi-2023.7.22-py3-none-any.whl
cffi-1.15.1-cp311-cp311-macosx_12_0_x86_64.whl
charset_normalizer-2.1.1-py3-none-any.whl
contourpy-1.1.1-cp311-cp311-macosx_12_0_x86_64.whl
cppy-1.2.1-py3-none-any.whl
cvxopt-1.3.0-cp311-cp311-macosx_12_0_x86_64.whl
cycler-0.11.0-py3-none-any.whl
cypari2-2.1.4-cp311-cp311-macosx_12_0_x86_64.whl
cysignals-1.11.4-cp311-cp311-macosx_12_0_x86_64.whl
decorator-5.1.1-py3-none-any.whl
deprecation-2.1.0-py2.py3-none-any.whl
docutils-0.19-py3-none-any.whl
editables-0.5-py3-none-any.whl
entrypoints-0.4-py3-none-any.whl
executing-1.2.0-py2.py3-none-any.whl
flit_core-3.9.0-py3-none-any.whl
fonttools-4.42.1-cp311-cp311-macosx_12_0_x86_64.whl
fpylll-0.6.0-cp311-cp311-macosx_12_0_x86_64.whl
gast-0.5.4-py3-none-any.whl
gmpy2-2.1.2-cp311-cp311-macosx_12_0_x86_64.whl
hatch_fancy_pypi_readme-23.1.0-py3-none-any.whl
hatch_nodejs_version-0.3.1-py3-none-any.whl
hatch_vcs-0.3.0-py3-none-any.whl
hatchling-1.18.0-py3-none-any.whl
idna-3.4-py3-none-any.whl
imagesize-1.4.1-py2.py3-none-any.whl
importlib_metadata-6.8.0-py3-none-any.whl
importlib_resources-6.0.1-py3-none-any.whl
ipykernel-6.6.0-py3-none-any.whl
ipython-8.6.0-py3-none-any.whl
ipython_genutils-0.2.0-py2.py3-none-any.whl
ipywidgets-8.0.2-py3-none-any.whl
jedi-0.18.1-py2.py3-none-any.whl
jupyter_client-7.4.4-py3-none-any.whl
jupyter_core-4.12.0-py3-none-any.whl
jupyterlab_pygments-0.1.2-py2.py3-none-any.whl
jupyterlab_widgets-3.0.3-py3-none-any.whl
kiwisolver-1.4.5-cp311-cp311-macosx_12_0_x86_64.whl
lrcalc-2.1-cp311-cp311-macosx_12_0_x86_64.whl
matplotlib-3.8.0-cp311-cp311-macosx_12_0_x86_64.whl
matplotlib_inline-0.1.6-py3-none-any.whl
memory_allocator-0.1.3-cp311-cp311-macosx_12_0_x86_64.whl
meson_python-0.14.0-py3-none-any.whl
mpmath-1.3.0-py3-none-any.whl
nest_asyncio-1.5.6-py3-none-any.whl
networkx-3.1-py3-none-any.whl
numpy-1.26.1-cp311-cp311-macosx_12_0_x86_64.whl
packaging-23.2-py3-none-any.whl
parso-0.8.3-py2.py3-none-any.whl
pathspec-0.10.2-py3-none-any.whl
pexpect-4.8.0-py2.py3-none-any.whl
pickleshare-0.7.5-py2.py3-none-any.whl
pip-23.3.1-py3-none-any.whl
pkgconfig-1.5.5-py3-none-any.whl
platformdirs-3.11.0-py3-none-any.whl
pluggy-1.3.0-py3-none-any.whl
ply-3.11-py2.py3-none-any.whl
pplpy-0.8.9-cp311-cp311-macosx_12_0_x86_64.whl
primecountpy-0.1.0-cp311-cp311-macosx_12_0_x86_64.whl
prompt_toolkit-3.0.24-py3-none-any.whl
ptyprocess-0.7.0-py2.py3-none-any.whl
pure_eval-0.2.2-py3-none-any.whl
py-1.11.0-py2.py3-none-any.whl
pybind11-2.11.1-py3-none-any.whl
pycparser-2.21-py2.py3-none-any.whl
pyparsing-3.1.1-py3-none-any.whl
pyproject_api-1.6.1-py3-none-any.whl
pyproject_metadata-0.7.1-py3-none-any.whl
pyrsistent-0.19.2-cp311-cp311-macosx_12_0_x86_64.whl
python_dateutil-2.8.2-py2.py3-none-any.whl
pythran-0.14.0-py3-none-any.whl
pytz-2023.3.post1-py3-none-any.whl
pytz_deprecation_shim-0.1.0.post0-py2.py3-none-any.whl
pyzmq-24.0.1-cp311-cp311-macosx_12_0_x86_64.whl
requests-2.28.1-py3-none-any.whl
rpy2-3.4.5-cp311-cp311-macosx_12_0_x86_64.whl
sagetex-3.6.1-py3-none-any.whl
scipy-1.11.3-cp311-cp311-macosx_12_0_x86_64.whl
setuptools-68.2.2-py3-none-any.whl
setuptools_scm-8.0.4-py3-none-any.whl
six-1.16.0-py2.py3-none-any.whl
snowballstemmer-2.2.0-py2.py3-none-any.whl
sphinx-5.2.3-py3-none-any.whl
sphinxcontrib_applehelp-1.0.2-py2.py3-none-any.whl
sphinxcontrib_devhelp-1.0.2-py2.py3-none-any.whl
sphinxcontrib_htmlhelp-2.0.0-py2.py3-none-any.whl
sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl
sphinxcontrib_qthelp-1.0.3-py2.py3-none-any.whl
sphinxcontrib_serializinghtml-1.1.5-py2.py3-none-any.whl
sphinxcontrib_websupport-1.2.4-py2.py3-none-any.whl
stack_data-0.6.1-py3-none-any.whl
sympy-1.12-py3-none-any.whl
tomli-2.0.1-py3-none-any.whl
tornado-6.2-cp37-abi3-macosx_12_0_x86_64.whl
traitlets-5.9.0-py3-none-any.whl
trove_classifiers-2023.8.7-py3-none-any.whl
typing_extensions-4.7.1-py3-none-any.whl
tzdata-2022.6-py2.py3-none-any.whl
tzlocal-5.0.1-py3-none-any.whl
urllib3-1.26.12-py2.py3-none-any.whl
vcversioner-2.16.0.0-py3-none-any.whl
wcwidth-0.2.5-py2.py3-none-any.whl
wheel-0.41.2-py3-none-any.whl
widgetsnbextension-4.0.8-py3-none-any.whl
zipp-3.11.0-py3-none-any.whl
+ sage -sh -c 'frobby genideal'
/usr/local/bin/bash: line 1: frobby: command not found
python: exit 127 (0.59 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi> bash -c 'set -ex; eval $SETENV; sage-config; ls $(sage-config SAGE_SPKG_WHEELS); sage -sh -c "frobby genideal"; /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python/bin/python -m pip install $(sage-config SAGE_SPKG_WHEELS)/*.whl' pid=91816
python: FAIL ✖ in 8.83 seconds
python-user: install_package> env PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python-user/bin python -I -m pip install --user --force-reinstall --no-deps /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.tmp/package/7/sage_conf-10.2rc0-py3-none-any.whl
python-user: commands[0]> bash -c 'set -ex; eval $SETENV; sage-config; ls $(sage-config SAGE_SPKG_WHEELS); sage -sh -c "frobby genideal"; /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python/bin/python -m pip install $(sage-config SAGE_SPKG_WHEELS)/*.whl'
+ eval export PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/usr/local/opt/polymake/bin:/usr/local/opt/texinfo/bin:/usr/local/opt/bzip2/bin:/Applications/google-cloud-sdk/bin:.:/Users/kwankyu/Workplace/bin:/usr/local/bin:/usr/local/sbin:/usr/texbin:/Applications/Macaulay2-1.20/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/Library/TeX/texbin:/Library/Apple/usr/bin:/Applications/Magma
++ export PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/usr/local/opt/polymake/bin:/usr/local/opt/texinfo/bin:/usr/local/opt/bzip2/bin:/Applications/google-cloud-sdk/bin:.:/Users/kwankyu/Workplace/bin:/usr/local/bin:/usr/local/sbin:/usr/texbin:/Applications/Macaulay2-1.20/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware Fusion.app/Contents/Public:/Library/TeX/texbin:/Library/Apple/usr/bin:/Applications/Magma
++ PATH=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/userbase/bin:/usr/local/opt/polymake/bin:/usr/local/opt/texinfo/bin:/usr/local/opt/bzip2/bin:/Applications/google-cloud-sdk/bin:.:/Users/kwankyu/Workplace/bin:/usr/local/bin:/usr/local/sbin:/usr/texbin:/Applications/Macaulay2-1.20/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/VMware
/usr/local/bin/bash: line 1: export: `Fusion.app/Contents/Public:/Library/TeX/texbin:/Library/Apple/usr/bin:/Applications/Magma': not a valid identifier
python-user: exit 1 (0.01 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi> bash -c 'set -ex; eval $SETENV; sage-config; ls $(sage-config SAGE_SPKG_WHEELS); sage -sh -c "frobby genideal"; /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/python/bin/python -m pip install $(sage-config SAGE_SPKG_WHEELS)/*.whl' pid=91926
.pkg-cpython311: _exit> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
  python: FAIL code 127 (8.83=setup[8.25]+cmd[0.59] seconds)
  python-user: FAIL code 1 (0.93=setup[0.92]+cmd[0.01] seconds)
  evaluation failed :( (9.91 seconds)

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 6, 2023

About /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12, it seem that my (homebrew) tox comes with python3.12...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 6, 2023

You can try running tox -e python-py311

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 7, 2023

I got

$ (cd pkgs/sage-conf_pypi && tox -r -e python-py311)
.pkg: remove tox env folder /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg
.pkg: install_requires> python -I -m pip install setuptools wheel
.pkg: _optional_hooks> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_sdist> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: get_requires_for_build_wheel> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
.pkg: install_requires_for_build_wheel> python -I -m pip install wheel
.pkg: build_wheel> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
python-py311: packaging backend failed (code=error: configure failed), with SystemExit: error: configure failed
configure: WARNING: unrecognized options: --disable-sage_conf
./configure: line 24948: timeout: command not found
configure: error: the python3 selected using --with-python=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python is not suitable
Traceback (most recent call last):
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
    dist.run_commands()
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
    self.run_command(cmd)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/dist.py", line 989, in run_command
    super().run_command(command)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/wheel/bdist_wheel.py", line 369, in run
    self.run_command("build")
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
    self.distribution.run_command(command)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/dist.py", line 989, in run_command
    super().run_command(command)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/command/build.py", line 131, in run
    self.run_command(cmd_name)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
    self.distribution.run_command(command)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/dist.py", line 989, in run_command
    super().run_command(command)
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
    cmd_obj.run()
  File "<string>", line 54, in run
distutils.errors.DistutilsSetupError: configure failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py", line 90, in run
    outcome = backend_proxy(parsed_message["cmd"], **parsed_message["kwargs"])
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py", line 32, in __call__
    return getattr(on_object, name)(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/build_meta.py", line 434, in build_wheel
    return self._build_with_temp_dir(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/build_meta.py", line 419, in _build_with_temp_dir
    self.run_setup()
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/build_meta.py", line 341, in run_setup
    exec(code, locals())
  File "<string>", line 136, in <module>
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/__init__.py", line 103, in setup
    return distutils.core.setup(**attrs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/core.py", line 185, in setup
    return run_commands(dist)
           ^^^^^^^^^^^^^^^^^^
  File "/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/lib/python3.12/site-packages/setuptools/_distutils/core.py", line 215, in run_commands
    raise SystemExit("error: " + str(msg))
SystemExit: error: configure failed
Backend: run command build_wheel with args {'wheel_directory': '/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/dist', 'config_settings': None, 'metadata_directory': None}
running bdist_wheel
running build
running build_py
Running cd /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/home/.sage/sage-10.2.rc0-Darwin-x86_64 && (. ./.homebrew-build-env 2> /dev/null; ./configure --prefix=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/home/.sage/sage-10.2.rc0-Darwin-x86_64/local --with-python=/Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python --enable-build-as-root --enable-download-from-upstream-url --with-system-python3=force --with-sage-venv --disable-notebook --disable-sagelib --disable-sage_conf --disable-doc)
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... ./config/install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
...
...
configure: will use system package and not install SPKG onetbb
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG python3...
checking whether any of bzip2 liblzma libffi zlib is installed as or will be installed as SPKG... no
checking for python3 >= 3.9.0, < 3.12.0 with modules sqlite3, ctypes, math, hashlib, crypt, socket, zlib, distutils.core, ssl, ensurepip... 
checking for /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python... /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python
checking ... whether /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python is good... no, Python 3.12.0 is too recent
configure failed; this may be caused by missing build prerequisites.
You can install the required build prerequisites using the following shell command

brew install bzip2 xz libffi

Backend: Wrote response {'code': 'error: configure failed', 'exc_type': 'SystemExit', 'exc_msg': 'error: configure failed'} to /var/folders/td/fw1q9ljs311ggyph77rs53_40000gn/T/pep517_build_wheel-6hmp0xby.json
.pkg: _exit> python /usr/local/Cellar/tox/4.11.3/libexec/lib/python3.12/site-packages/pyproject_api/_backend.py True setuptools.build_meta
  python-py311: FAIL code error: configure failed (39.63 seconds)
  evaluation failed :( (39.77 seconds)
error: configure failed

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2023

Hmmm... this looks suspicious:
./configure: line 24948: timeout: command not found

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2023

But the real problem is that it's still using Python 3.12
checking ... whether /Users/kwankyu/GitHub/sage-dev/pkgs/sage-conf_pypi/.tox/.pkg/bin/python is good... no, Python 3.12.0 is too recent

@mkoeppe mkoeppe force-pushed the sage_conf_pypi_fix branch from 1f30d72 to 19d1ea7 Compare November 7, 2023 01:36
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2023

How py311-user is different from py311?

It tests that pip install --user works

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

Thanks very much!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

Marking it as a blocker so that it gets merged in the 10.2 release.

@tornaria
Copy link
Contributor

tornaria commented Nov 8, 2023

This is idea of patching "on-the-fly" seems really broken. From https://github.com/sagemath/sage/actions/runs/6785240332/job/18443170385?pr=35148

Applying: Merge https://github.com/sagemath/sage/pull/36671
Applying: Merge https://github.com/sagemath/sage/pull/36668
Applying: Merge https://github.com/sagemath/sage/pull/36663
Applying: Merge https://github.com/sagemath/sage/pull/36661
Applying: Merge https://github.com/sagemath/sage/pull/36659
Applying: Merge https://github.com/sagemath/sage/pull/36652
Applying: Merge https://github.com/sagemath/sage/pull/36648
Applying: Merge https://github.com/sagemath/sage/pull/36636
Applying: Merge https://github.com/sagemath/sage/pull/36599
Applying: Merge https://github.com/sagemath/sage/pull/36534
Applying: Merge https://github.com/sagemath/sage/pull/36533
Patch failed at 0011 Merge https://github.com/sagemath/sage/pull/36533

There seems to a very easy solution to "CI is broken on releases" without having to automerge PRs: if @vbraun would make a PR when a new release is ready and then only cut the release if CI passes. What would be the downside of that?

I mean, 10.2.rc0 was released three days ago, and we already have 11 patches applied? wtf?

To make things more egregious, in a different run: https://github.com/sagemath/sage/actions/runs/6785240365/job/18443164416?pr=35148 has all 11 merges applied.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

patching "on-the-fly" seems really broken

Looks like a bug in the script that applies the patches using git am, thanks. This will go away with #36498

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

I mean, 10.2.rc0 was released three days ago, and we already have 11 patches applied?

They are the blockers for the 10.2 release. As documented in https://doc.sagemath.org/html/en/developer/review.html#the-release-process

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 8, 2023

patching "on-the-fly" seems really broken

Looks like a bug in the script that applies the patches using git am

Manual check out and merge has no problem.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 8, 2023

This will go away with #36498

I think we need an independent solution.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 8, 2023

This is idea of patching "on-the-fly" seems really broken. From https://github.com/sagemath/sage/actions/runs/6785240332/job/18443170385?pr=35148

We cannot blame the idea itself from this instance of failure.

Fortunately, there is no disaster from the failure.

@tornaria
Copy link
Contributor

tornaria commented Nov 8, 2023

I mean, 10.2.rc0 was released three days ago, and we already have 11 patches applied?

They are the blockers for the 10.2 release. As documented in https://doc.sagemath.org/html/en/developer/review.html#the-release-process

Then overloading the same label for "blockers for 10.2 release" and "hotfix patches" doesn't seem like a good idea (even if you disagree with my opinion that "hotfix patches" is a bad idea).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

Perhaps, but because of the peculiarities of our release process I think it's quite appropriate that people who work on PRs in the release candidate stage get their PRs tested with what will be merged in the release.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 8, 2023

I think I've just found & fixed what went wrong when applying this PR as a fix.

Copy link

github-actions bot commented Nov 8, 2023

Documentation preview for this PR (built with commit 11a8d35; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 9, 2023

Perhaps, but because of the peculiarities of our release process I think it's quite appropriate that people who work on PRs in the release candidate stage get their PRs tested with what will be merged in the release.

This is an argument for only applying positive-reviewed blockers as hotfixes.

@tornaria
Copy link
Contributor

tornaria commented Nov 9, 2023

Perhaps, but because of the peculiarities of our release process I think it's quite appropriate that people who work on PRs in the release candidate stage get their PRs tested with what will be merged in the release.

I give up. Because of the peculiarities of sagemath CI, I'll just keep ignoring it.

@kwankyu
Copy link
Collaborator

kwankyu commented Nov 9, 2023

We introduced hot-fixes mechanism to avoid false negatives in ci. There should be zero possibility that hot-fixes themselves cause false negatives.

@vbraun vbraun merged commit b7d3401 into sagemath:develop Nov 10, 2023
13 of 20 checks passed
@mkoeppe mkoeppe deleted the sage_conf_pypi_fix branch November 10, 2023 17:29
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 4, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
This is a new maintenance command for adding/updating `# sage_setup:
distribution` directives at the top of source files.

Based on a discussion in
sagemath#35884 (comment)

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36533 (CI fix)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36135
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 5, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
This is a new maintenance command for adding/updating `# sage_setup:
distribution` directives at the top of source files.

Based on a discussion in
sagemath#35884 (comment)

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Part of: sagemath#29705
- Cherry-picked from: sagemath#35095
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36533 (CI fix)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36135
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 2, 2024
… `pyproject.toml`

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- In part split out from sagemath#36489
- Part of sagemath#33577
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36533 (which changes setup.cfg, merged here)
- Depends on sagemath#36885

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36561
Reported by: Matthias Köppe
Reviewer(s): François Bissey
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
… `pyproject.toml`

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- In part split out from sagemath#36489
- Part of sagemath#33577
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36533 (which changes setup.cfg, merged here)
- Depends on sagemath#36885

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36561
Reported by: Matthias Köppe
Reviewer(s): François Bissey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants