-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace relative imports by absolute ones in sage.libs
except .ntl
#36612
Conversation
@@ -0,0 +1,105 @@ | |||
# sage_setup: distribution = sagemath-pari |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slipped in while cherry picking, I'll fix it
7c57c9f
to
486508d
Compare
Documentation preview for this PR (built with commit 486508d; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For the next time, please just add another commit fixing the issue instead force-pushing everything. As a referee I don't want to check everything again, only the changed parts (i.e here that you removed the file). Thanks
As these commits are cherry-picks from #35095, it's more important for me to keep the commits in clear relation to the original commits. |
📝 Checklist
⌛ Dependencies