Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemath-{objects,categories} pyproject.toml: Add 'external' section according to draft PEP 725 #37486

Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 27, 2024

As done in #37482 (unbundled from #37446) for sagemath-standard.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 27, 2024
@mkoeppe mkoeppe requested a review from saraedum March 20, 2024 23:13
@mkoeppe mkoeppe force-pushed the pyproject_external_sagemath_categories branch from 31f1bf9 to f460afc Compare March 26, 2024 01:42
@mkoeppe mkoeppe force-pushed the pyproject_external_sagemath_categories branch from f460afc to 0c09460 Compare April 1, 2024 00:47
Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit 0c09460; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 17, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 20, 2024
… 'external' section according to draft PEP 725

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

As done in sagemath#37482 (unbundled from sagemath#37446) for **sagemath-standard**.

- This information will be used in the skeleton generator in
pyodide/pyodide#4438

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37486
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 2d37187 into sagemath:develop Apr 27, 2024
16 of 36 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants