Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.{calculus,functions,numerical,symbolic}: Docstring/doctest cosmetics, # needs #37715

Merged
merged 3 commits into from
May 2, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 1, 2024

Cherry-picked from #35095.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit e56c10b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@DaveWitteMorris
Copy link
Member

I'm sorry, but I can't review this, because I don't understand modularization.

@DaveWitteMorris DaveWitteMorris removed their request for review April 2, 2024 02:09
@mkoeppe mkoeppe requested a review from kwankyu April 3, 2024 20:10
@mkoeppe mkoeppe force-pushed the sage_calculus_doctest_cosmetics branch from e9ff69a to ef23716 Compare April 10, 2024 02:18
@kwankyu
Copy link
Collaborator

kwankyu commented Apr 25, 2024

I'm sorry, but I can't review this, because I don't understand modularization.

@mkoeppe For this business of maintaining the "# needs" or "# optional" tags, I think that it should be obvious to a PR author how to modify or add or delete those tags. I guess that "Test modularized distributions" of "B&T" would (could) annotate "Files changed" with appropriate messages on how to modify them. If I am right, is it working now or are you working for it to work?

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 25, 2024

Otherwise, lgtm.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2024

For this business of maintaining the "# needs" or "# optional" tags, I think that it should be obvious to a PR author how to modify or add or delete those tags. I guess that "Test modularized distributions" of "B&T" would (could) annotate "Files changed" with appropriate messages on how to modify them. If I am right, is it working now or are you working for it to work?

This can only be done after the distributions in #35095 have been merged into develop.
In the current branch, these tags just cannot be tested yet.

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 25, 2024

I see. Thanks.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2024

Thank you!

@vbraun
Copy link
Member

vbraun commented Apr 28, 2024

fail, see CI

@mkoeppe mkoeppe force-pushed the sage_calculus_doctest_cosmetics branch from ef23716 to e56c10b Compare April 28, 2024 19:14
@vbraun vbraun merged commit 19b06ac into sagemath:develop May 2, 2024
13 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants