Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc, gfortran: Update to 13.2.0; remove debian-buster-gcc_spkg from CI #38008

Merged
merged 30 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 16, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

faisalfakhro and others added 27 commits April 25, 2024 17:30
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 16, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 16, 2024

Testing (ci-37203-37834-37919-37931-38008-38009) at https://github.com/mkoeppe/sage/actions/runs/9105145243 (Linux), https://github.com/mkoeppe/sage/actions/runs/9105145246 (macOS)

Copy link

github-actions bot commented May 16, 2024

Documentation preview for this PR (built with commit 4187f5c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 16, 2024

@mkoeppe mkoeppe changed the title gcc, gfortran: Update to 13.2.0 gcc, gfortran: Update to 13.2.0; remove debian-buster-gcc_spkg from CI May 16, 2024
@mkoeppe mkoeppe requested review from culler and jhpalmieri May 16, 2024 19:23
@jhpalmieri
Copy link
Member

I'm confused: which parts of this PR remove debian-buster-gcc_spkg from the CI?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 17, 2024

... the part that I forgot to commit ...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 17, 2024

Here it is.

@jhpalmieri
Copy link
Member

jhpalmieri commented May 17, 2024

On an Apple Silicon machine, latest OS and Xcode and homebrew, gfortran builds and works fine. Using ./configure --with-system-gcc=no, several packages fail to build: lcalc, givaro, ppl, with errors:

[spkg-build] Undefined symbols for architecture arm64:
[spkg-build]   "___emutls_v.avma", referenced from:
[spkg-build]       _rdiviiz in libLfunction.1.0.1.dylib-master.o
[spkg-build]       _cxcompotor.constprop.0 in libLfunction.1.0.1.dylib-master.o
[spkg-build]       _gtofp.constprop.0 in libLfunction.1.0.1.dylib-master.o
[spkg-build]       __Z6data_EPcS_S_S_S_iPd in libLfunction.1.0.1.dylib-master.o
[spkg-build]   "___emutls_v.pari_mainstack", referenced from:
[spkg-build]       _cxcompotor.constprop.0 in libLfunction.1.0.1.dylib-master.o
[spkg-build]       _gtofp.constprop.0 in libLfunction.1.0.1.dylib-master.o
[spkg-build]       __Z6data_EPcS_S_S_S_iPd in libLfunction.1.0.1.dylib-master.o
[spkg-build] ld: symbol(s) not found for architecture arm64

and

[spkg-install] Undefined symbols for architecture arm64:
[spkg-install]   "__ZlsRSoPK12__mpz_struct", referenced from:
[spkg-install]       __ZNK6Givaro7Integer5printERSo in libgivaro.9.dylib-master.o
[spkg-install]       __ZN6GivarolsERSoRKNS_7IntegerE in libgivaro.9.dylib-master.o
[spkg-install]   "__ZrsRSiP12__mpz_struct", referenced from:
[spkg-install]       __ZN6GivarorsERSiRNS_7IntegerE in libgivaro.9.dylib-master.o
[spkg-install] ld: symbol(s) not found for architecture arm64

and

[spkg-install] Undefined symbols for architecture arm64:
[spkg-install]   "__ZlsRSoPK12__mpq_struct", referenced from:
[spkg-install]       __ZN12_GLOBAL__N_116write_polyhedronERSoRKN23Parma_Polyhedra_Library12C_PolyhedronENS_14RepresentationE in ppl_lcdd.o
[spkg-install]   "__ZlsRSoPK12__mpz_struct", referenced from:
[spkg-install]       __ZN12_GLOBAL__N_113guarded_writeI10__gmp_exprIA1_12__mpz_structS3_EEEvRSoRKT_ in ppl_lcdd.o
[spkg-install]   "__ZrsRSiP12__mpq_struct", referenced from:
[spkg-install]       __ZN12_GLOBAL__N_117read_coefficientsERSiNS_11Number_TypeERSt6vectorI10__gmp_exprIA1_12__mpz_structS5_ESaIS6_EERS6_ in ppl_lcdd.o
[spkg-install]   "__ZrsRSiP12__mpz_struct", referenced from:
[spkg-install]       __ZN12_GLOBAL__N_117read_coefficientsERSiNS_11Number_TypeERSt6vectorI10__gmp_exprIA1_12__mpz_structS5_ESaIS6_EERS6_ in ppl_lcdd.o
[spkg-install] ld: symbol(s) not found for architecture arm64

respectively.

This is with the current PR on top of 10.4.beta5 — I can't build beta6 because of the problems with fflas-fpack. I also don't know if these are new to this version of gcc, but I'll try to check.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 17, 2024

I don't think we have supported building with gcc from SPKG on macOS

@jhpalmieri
Copy link
Member

I don't think we have supported building with gcc from SPKG on macOS

Okay, then I won't worry about it. I realize that I can't check if the problems are new because the whole point is that I can't build the old gcc spkg.

@culler
Copy link
Contributor

culler commented May 18, 2024

I was able to build gfortran-13.2.0 from this PR with no errors. (There were around 40,000 warnings, but I think that is normal.). This was on an Intel mac mini running macOS 14.4.1.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 18, 2024

Thanks!

@vbraun vbraun merged commit aa6f8a7 into sagemath:develop May 25, 2024
13 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gfortran doesn't build on latest OS X + Xcode + Homebrew
5 participants