Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.geometry.hyperbolic_space: Add # needs #38236

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 18, 2024

Some of these are from the use of a matrix norm, which # needs scipy.

Also a norm-related change in sage.modules.free_module_integer - avoiding use of norm, which send us into symbolics land, in favor of just comparing norm squares

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 1cce2b8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 18, 2024

Thanks!

@vbraun vbraun merged commit db87eb3 into sagemath:develop Jul 24, 2024
24 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the norm_needs branch July 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants