Deprecate is_LaurentSeriesRing, is_MPowerSeriesRing, is_PowerSeriesRing
#38290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 23, 2024 11:57
…FIX=_generic" "CLASS='MPolynomialRing';SUFFIX=_base" "CLASS='QuotientRing';SUFFIX=_nc" "CLASS='LaurentSeries|MPowerSeries|MPolynomialIdeal|PowerSeries';SUFFIX=" ; do eval "$a"; git --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
… --no-pager grep -l -E 'is_('$CLASS')' src/sage | xargs sed -E -i.bak 's/import is_('$CLASS')/import \1'$SUFFIX'/;/^ +/s/is_('$CLASS')[(]([^()]*([(][^()]*[)])?[^()]*)[)]/isinstance(\2, \1'$SUFFIX')/g'; done
mkoeppe
changed the title
is_LaurentSeriesRingis_LaurentSeriesRing, is_MPowerSeriesRing, is_PowerSeriesRing
…s of deprecated is_ functions
|
Documentation preview for this PR (built with commit 1fe1648; changes) is ready! 🎉 |
added 9 commits
June 26, 2024 20:16
…se of is_LaurentSeriesRing
…_PowerSeriesRing, is_MPowerSeriesRing
…eriesRing, is_PowerSeriesRing
|
Thank you! |
added 3 commits
July 22, 2024 13:10
|
Merge conflict |
added 2 commits
July 26, 2024 17:16
|
|
Thanks, I need to merge the updated dependency |
|
Thanks again. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
…ing`, `is_PowerSeriesRing`
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Part of
- sagemath#32414
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- Depends on sagemath#38266 (merged here)
URL: sagemath#38290
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
is_Classfunctions, create abstract base classes to enable modularization #32414📝 Checklist
⌛ Dependencies
is_Ideal,is_LaurentSeries,is_MPolynomialIdeal,is_MPolynomialRing,is_MPowerSeries,is_PolynomialQuotientRing,is_PolynomialRing,is_PolynomialSequence,is_PowerSeries,is_QuotientRing#38266 (merged here)