Upgrade database_knotinfo to version 2024.10.1 #38822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For non-hyperbolic knots, the |
|
Documentation preview for this PR (built with commit 70adf3a; changes) is ready! 🎉 |
tscrim
approved these changes
Oct 24, 2024
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
tscrim
approved these changes
Oct 25, 2024
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Thank you. LGTM. |
Thanks too! |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 14, 2024
…date in build/pkgs
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This PR just adds the autogenerated package update (produced by `sage
--package update database_knotinfo 2024.10.1`) which was missing in
sagemath#38822.
@tscrim I'm sorry that I missed that in sagemath#38822.
### 📝 Checklon
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38885
Reported by: Sebastian Oehms
Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
database_knotinfoversion 2024.10.1 is no longer compatible with Sage because the syntax for 16 knots for which two braid notations are recorded has changed (see the corresponding Release Notes).This is fixed by this PR. In addition, two new fields (
geometric_typeandcosmetic_crossing) added in this version are used to implement corresponding methods (is_hyperbolicandcosmetic_crossing_conjecture_verified) of the interface.📝 Checklist
⌛ Dependencies