Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #79 and Bug #58, handle save() asynchronously #233

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Issue #79 and Bug #58, handle save() asynchronously #233

merged 2 commits into from
Oct 25, 2017

Conversation

mvoorberg
Copy link
Contributor

#79
#58

Added callbacks on model .save() when using attempt limiting. Added tests to hit the new cases, including the error ones.

@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+2.2%) to 96.954% when pulling 0f4db8b on 4umfreak:master into d98e0b3 on saintedlama:master.

@saintedlama
Copy link
Owner

Thanks for the PR. Even code coverage increased 🎉

@saintedlama saintedlama merged commit a2bd7bf into saintedlama:master Oct 25, 2017
@mvoorberg
Copy link
Contributor Author

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvoorberg @coveralls @saintedlama