Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add configuration to vault to choose what type of connection to use #61857

Closed
Ch3LL opened this issue Mar 25, 2022 · 0 comments · Fixed by #62906
Closed

[FEATURE REQUEST] Add configuration to vault to choose what type of connection to use #61857

Ch3LL opened this issue Mar 25, 2022 · 0 comments · Fixed by #62906
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. Vault VMware

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 25, 2022

When using vault modules and pillars there are two functions when getting the config information to use to connect to vault:

_get_token_and_url_from_master() and _use_local_config()

_get_token_and_url_from_master() is normally used when using the vault module to query the details from the minion to master. But when using pillar this function renders the pillar data on the master and impersonates the minion. This function requires that the master has permissions to create vault tokens on behalf of the minions. Adding a config to use _use_local_config() would allow someone to render vault pillar data without adding extra permissions for the master if they don't intend on using separate policies per minion. This issue is created to track the work to make it configurable to set which method you want to use.

@Ch3LL Ch3LL added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Mar 25, 2022
@Ch3LL Ch3LL added this to the Sulphur v3006.0 milestone Mar 25, 2022
@Ch3LL Ch3LL self-assigned this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Vault VMware
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants