Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] aptpkg execution module doesn't send kwargs to apt #63847

Closed
wasabi222 opened this issue Mar 9, 2023 · 1 comment
Closed

[BUG] aptpkg execution module doesn't send kwargs to apt #63847

wasabi222 opened this issue Mar 9, 2023 · 1 comment
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior

Comments

@wasabi222
Copy link
Contributor

Description
Line is here: https://github.com/saltstack/salt/blob/master/salt/modules/aptpkg.py#L1006

Because no kwargs are sent to _call_apt, it's not possible to override scope=True in that function (located here: https://github.com/saltstack/salt/blob/master/salt/modules/aptpkg.py#L346 ). The line above should be out = _call_apt(cmd, **kwargs) so that scope can be overridden if desired.
@wasabi222 wasabi222 added Bug broken, incorrect, or confusing behavior needs-triage labels Mar 9, 2023
@garethgreenaway garethgreenaway self-assigned this Mar 24, 2023
@garethgreenaway garethgreenaway mentioned this issue Mar 24, 2023
Merged
3 tasks
@garethgreenaway
Copy link
Contributor

Closed by #63955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethgreenaway @wasabi222