You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
). rpm -qa does digest and signature checking by default. list_pkgs is does not need to verify checksums and signatures and therefore can reduce the time to list the packages by disabling the digest and signature checking with the --nodigest and --nosignature flags.
Describe the solution you'd like
Add the --nodigest and --nosignature to the cmd variable that is passed to cmd.run in the list_pkgs function of salt/modules/yumpkg.py
Additional context
Here are a couple of example timings of rpm -qa before and adding the flags on my rhel 8 ec2 instance:
@bdrx312 I know you were working on a PR were you able to get that started?
No I have been busy and haven't had time to figure out how to setup a saltstack development environment on Windows with vagrant yet. I created a fork and committed the change. If someone wants take the changes and pick up from there they can see it here https://github.com/bdrx312/salt. I am not sure when I will have time.
whytewolf
added
Bug
broken, incorrect, or confusing behavior
and removed
Feature
new functionality including changes to functionality and code refactors, etc.
labels
Sep 11, 2023
moving this to bug as the speed up is enough that this could be considered a bug in speed.
whytewolf
changed the title
[FEATURE REQUEST] Add --nodigest and --nosignature flags to rpm call in yumpkg module
[BUG] Add --nodigest and --nosignature flags to rpm call in yumpkg module
Sep 11, 2023
Is your feature request related to a problem? Please describe.
yumpkg
list_pkgs
makes a subprocess command call torpm -qa
to list the packages (salt/salt/modules/yumpkg.py
Lines 747 to 752 in caa5e39
rpm -qa
does digest and signature checking by default. list_pkgs is does not need to verify checksums and signatures and therefore can reduce the time to list the packages by disabling the digest and signature checking with the--nodigest
and--nosignature
flags.Describe the solution you'd like
Add the
--nodigest
and--nosignature
to thecmd
variable that is passed tocmd.run
in thelist_pkgs
function of salt/modules/yumpkg.pyAdditional context
Here are a couple of example timings of
rpm -qa
before and adding the flags on my rhel 8 ec2 instance:The text was updated successfully, but these errors were encountered: