You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
If running extfs.tune via the module.run state, the Result is always "True" (successful) even if the command fails. See state output below:
local:
----------
ID: stuff
Function: module.run
Result: True
Comment: extfs.tune: ['tune2fs: No such file or directory while trying to open /dev/donkey', "Couldn't find valid filesystem superblock.", 'tune2fs 1.44.5 (15-Dec-2018)']
Started: 15:25:14.681118
Duration: 225026.936 ms
Changes:
----------
extfs.tune:
- tune2fs: No such file or directory while trying to open /dev/donkey
- Couldn't find valid filesystem superblock.
- tune2fs 1.44.5 (15-Dec-2018)
Setup
SLS file mimicing the extfs.tune command from the documentation:
Steps to Reproduce the behavior
Run a state.apply on the SLS file above. Assuming you don't have a "donkey" device, the execution module will fail with a successful state run.
Expected behavior
Execution module failures should produce state failures.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
Salt Version:
Salt: 3007.0+0na.f0c3a19Python Version:
Python: 3.7.3 (default, Oct 11 2023, 09:51:27)Dependency Versions:
cffi: 1.15.1cherrypy: Not Installeddateutil: Not Installeddocker-py: Not Installedgitdb: Not Installedgitpython: Not InstalledJinja2: 3.1.2libgit2: Not Installedlooseversion: 1.0.3M2Crypto: Not InstalledMako: Not Installedmsgpack: 1.0.5msgpack-pure: Not Installedmysql-python: Not Installedpackaging: 23.2pycparser: 2.21pycrypto: 2.6.1pycryptodome: 3.19.0pygit2: Not Installedpython-gnupg: Not InstalledPyYAML: 6.0.1PyZMQ: 25.0.2relenv: Not Installedsmmap: Not Installedtimelib: Not InstalledTornado: 4.5.3ZMQ: 4.3.4Salt Extensions:
salt-analytics-framework: 0.5.0System Versions:
dist: debian 10.13 busterlocale: UTF-8machine: x86_64release: 4.19.0-25-amd64system: Linuxversion: Debian GNU/Linux 10.13 buster
The text was updated successfully, but these errors were encountered:
Description
If running
extfs.tune
via themodule.run
state, the Result is always "True" (successful) even if the command fails. See state output below:Setup
SLS file mimicing the
extfs.tune
command from the documentation:Steps to Reproduce the behavior
Run a
state.apply
on the SLS file above. Assuming you don't have a "donkey" device, the execution module will fail with a successful state run.Expected behavior
Execution module failures should produce state failures.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)The text was updated successfully, but these errors were encountered: