New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript best Practices-Exercise #6

Open

saluumaa opened this issue Mar 3, 2023 · 0 comments

Owner

saluumaa commented Mar 3, 2023

There are some issues with this project kindly consider fixing them:

To-do-List/src/modules/CRUD.js

Line 57 in e5e50fa

const editTodo = (todoId) => {

This function is doing two tasks, kindly try to fix it by taking the task description event outside of the function and link them.
To-do-List/src/modules/CRUD.js

Line 37 in e5e50fa

listContainer.addEventListener('click', (e) => {

This event listener has many comments inside it, please get rid the inline comments for a clean code.
To-do-List/src/modules/CRUD.js

Line 90 in e5e50fa

function checkTodo(todoId) {

Kindly try to adjust this block of code and use ES6 arrow function instead of normal function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment