Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4] Bug: Champion data folder does not exists #5

Merged
merged 1 commit into from
Sep 7, 2024
Merged

[4] Bug: Champion data folder does not exists #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions helpers/champion_data_helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ const fs = require('fs');
const fetch = require("node-fetch");
const { resolve } = require('path');

const dataFilePath = './data/champion_data.json';
const DATA_FILE_PATH = './data/champion_data.json';
const DATA_FOLDER_PATH = './data';

let version;

Expand All @@ -11,20 +12,23 @@ exports.updateChampionData = function (lastestVersion) {
try {
let createOrUpdateFile = false;

if (!fs.existsSync(dataFilePath)) {
if (!fs.existsSync(DATA_FILE_PATH)) {
//if the file doesn't exist, we want to create it.
createOrUpdateFile = true;
} else {
//if the file does exist, we want to update it if necessary.
const championData = ReadFileSync(dataFilePath);
const championData = readFileSync(DATA_FILE_PATH);
if (championData.version !== lastestVersion) {
createOrUpdateFile = true;
}
}

if (createOrUpdateFile) {
fetchChampionData(lastestVersion).then(new_champion_data => {
WriteFileSync(dataFilePath, JSON.stringify(new_champion_data));
if (!fs.existsSync(DATA_FOLDER_PATH)) {
createFolder(DATA_FOLDER_PATH);
}
writeFileSync(DATA_FILE_PATH, JSON.stringify(new_champion_data));
console.log("Champion data file was updated. New version: " + lastestVersion);
});
} else {
Expand All @@ -36,7 +40,7 @@ exports.updateChampionData = function (lastestVersion) {
}

exports.getChampions = function () {
const champion_data = ReadFileSync(dataFilePath);
const champion_data = readFileSync(DATA_FILE_PATH);
return champion_data.data;
}

Expand All @@ -45,12 +49,16 @@ const fetchChampionData = function (version) {
return fetch(`http://ddragon.leagueoflegends.com/cdn/${version}/data/en_US/champion.json`).then(res => res.json()).then(json => json).catch(console.error);
}

const ReadFileSync = function (filePath) {
const readFileSync = function (filePath) {
const data = fs.readFileSync(filePath);
return JSON.parse(data);
}

const WriteFileSync = function (filePath, jsonString) {
const createFolder = function (folderPath) {
fs.mkdirSync(folderPath)
}

const writeFileSync = function (filePath, jsonString) {
fs.writeFileSync(filePath, jsonString);
}

Expand Down